Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Incorrectly using a non-generic type with type parameters now produces a helpful Python error instead of throwing NullReferenceException#1326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lostmsu merged 4 commits intopythonnet:masterfromtminka:generics-exception
Dec 18, 2020

Conversation

tminka
Copy link
Contributor

What does this implement/fix? Explain your changes.

Fixes#1325

Does this close any currently open issues?

Fixes#1325

Any other comments?

...

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself toAUTHORS
  • Updated theCHANGELOG

@dnfadmin
Copy link

dnfadmin commentedDec 17, 2020•
edited
Loading

CLA assistant check
All CLA requirements met.

@tminka
Copy link
ContributorAuthor

The tests appear to be failing for the reasons addressed by PR#1260. Applying those changes should make the tests pass.

@lostmsu
Copy link
Member

@tminka I am a bit lost. In the comment to that PR you mentioned, thatde7e1ac solves the issue. But the PR itself does not contain that commit.

Copy link
Member

@filmorfilmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Very nice addition, thank you. If you can just move the test to Python, this is good to go :)

@tminka
Copy link
ContributorAuthor

@lostmsu My only point was that the test failures are the same as the ones in the current master, and those are due to finalization/deallocation bugs.

@tminkatminkaforce-pushed thegenerics-exception branch 2 times, most recently fromf2ceaf6 to24683d0CompareDecember 18, 2020 16:25
@filmor
Copy link
Member

Please make this just a normal Python test. You can run pytest from within VisualStudio using our normal APIs (import pytest; pytest.main()) if you want.

@filmor
Copy link
Member

Ah, I see that you have already moved the test. Would you be okay with splitting theEmbeddedPythonTest into a separate PR? I think this does have merit, but it's independent of the actual fix here.

…s a helpful Python error instead of throwing NullReferenceException
Removed unused GenericUtil.GenericsForType.Other code quality improvements.
Added EmbeddedPythonTest with the capability to run any desired Python tests within NUnit.
@lostmsulostmsu merged commitd9e15a7 intopythonnet:masterDec 18, 2020
@tminkatminka deleted the generics-exception branchDecember 21, 2020 00:07
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@lostmsulostmsulostmsu left review comments

@filmorfilmorfilmor requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NullReferenceException when non-generic type is given type parameters
4 participants
@tminka@dnfadmin@lostmsu@filmor
[8]ページ先頭
©2009-2025 Movatter.jp