Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Detect the size of wchar_t (aka Runtime.UCS) at runtime using PyUnicode_GetMax#1298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lostmsu merged 1 commit intopythonnet:masterfromlosttech:features/RuntimeUcsSize
Nov 30, 2020

Conversation

lostmsu
Copy link
Member

What does this implement/fix? Explain your changes.

This determines the value forRuntime.UCS at runtime instead of using compile-time defines, removing the need for separate builds ofPython.Runtime.

Does this close any currently open issues?

N/A

Any other comments?

PyUnicode_GetMax is deprecated, but preserved for compatibility.

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself toAUTHORS
  • Updated theCHANGELOG

@lostmsulostmsu requested a review fromfilmorNovember 30, 2020 02:41
@codecov-io
Copy link

codecov-io commentedNov 30, 2020•
edited
Loading

Codecov Report

Merging#1298 (4d43b54) intomaster (182faed) willdecrease coverage by0.08%.
The diff coverage isn/a.

Impacted file tree graph

@@            Coverage Diff             @@##           master    #1298      +/-   ##==========================================- Coverage   87.97%   87.88%   -0.09%==========================================  Files           1        1                Lines         291      289       -2     ==========================================- Hits          256      254       -2  Misses         35       35
FlagCoverage Δ
setup_linux65.05% <ø> (-0.25%)⬇️
setup_windows74.04% <ø> (-0.18%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
setup.py87.88% <ø> (-0.09%)⬇️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update182faed...4d43b54. Read thecomment docs.

@markuspalme
Copy link

This could possibly solve#114.

@filmor
Copy link
Member

Great, I wasn't aware ofPyUnicode_GetMax. We should probably find a more sustainable solution at some point (as the function is explicitly deprecated), but this will do nicely for now :)

@lostmsulostmsu merged commit67c6d11 intopythonnet:masterNov 30, 2020
@lostmsulostmsu deleted the features/RuntimeUcsSize branchNovember 30, 2020 17:50
@sekkit
Copy link

ctypes.sizeof(ctypes.c_wchar) would do the trick

@filmor
Copy link
Member

@lostmsu It looks like the symbol is scheduled for removal for Python 3.10, I'll look into this s.t. we can start supporting 3.10 earlier than we could with 3.9 :)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@filmorfilmorfilmor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@lostmsu@codecov-io@markuspalme@filmor@sekkit
[8]ページ先頭
©2009-2025 Movatter.jp