Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Allow creating new .NET arrays from Python using Array[T](dim1, dim2,…) syntax#1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lostmsu merged 1 commit intopythonnet:masterfromlosttech:features/ArrayFromShape
Nov 24, 2020

Conversation

lostmsu
Copy link
Member

What does this implement/fix? Explain your changes.

This handles a few new argument combinations intp_new of .NET array types:

  1. A single integer to create a one-dimensional array of specified size.
  2. Multiple integers passed as arguments (e.g.Array[T](3,5,7)) to create a multidimensional array.

It processes all exceptions specified inhttps://docs.microsoft.com/en-us/dotnet/api/system.array.createinstance?view=net-5.0#System_Array_CreateInstance_System_Type_System_Int64___

Does this close any currently open issues?

fixes#251

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself toAUTHORS
  • Updated theCHANGELOG

christabella reacted with eyes emoji
@lostmsulostmsuforce-pushed thefeatures/ArrayFromShape branch from96cee3e to1d17421CompareNovember 24, 2020 04:11
@codecov-io
Copy link

codecov-io commentedNov 24, 2020
edited
Loading

Codecov Report

Merging#1291 (1d17421) intomaster (c81c3c3) willnot change coverage.
The diff coverage isn/a.

Impacted file tree graph

@@           Coverage Diff           @@##           master    #1291   +/-   ##=======================================  Coverage   87.97%   87.97%           =======================================  Files           1        1             Lines         291      291           =======================================  Hits          256      256             Misses         35       35
FlagCoverage Δ
setup_linux65.29% <ø> (ø)
setup_windows74.22% <ø> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.


Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatec81c3c3...1d17421. Read thecomment docs.

@lostmsulostmsu requested a review fromfilmorNovember 24, 2020 21:11
@lostmsulostmsu merged commit182faed intopythonnet:masterNov 24, 2020
@lostmsulostmsu deleted the features/ArrayFromShape branchNovember 24, 2020 22:08
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@filmorfilmorfilmor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Array instantiation does not work with clean syntax
3 participants
@lostmsu@codecov-io@filmor

[8]ページ先頭

©2009-2025 Movatter.jp