- Notifications
You must be signed in to change notification settings - Fork774
Allow creating new .NET arrays from Python using Array[T](dim1, dim2,…) syntax#1291
Merged
lostmsu merged 1 commit intopythonnet:masterfromNov 24, 2020
Merged
Conversation
46e7c65 to96cee3eCompare96cee3e to1d17421Comparecodecov-io commentedNov 24, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #1291 +/- ##======================================= Coverage 87.97% 87.97% ======================================= Files 1 1 Lines 291 291 ======================================= Hits 256 256 Misses 35 35
Flags with carried forward coverage won't be shown.Click here to find out more. Continue to review full report at Codecov.
|
filmor approved these changesNov 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This handles a few new argument combinations in
tp_newof .NET array types:Array[T](3,5,7)) to create a multidimensional array.It processes all exceptions specified inhttps://docs.microsoft.com/en-us/dotnet/api/system.array.createinstance?view=net-5.0#System_Array_CreateInstance_System_Type_System_Int64___
Does this close any currently open issues?
fixes#251
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG