NotificationsYou must be signed in to change notification settings
Fork748
Star5.1k

Ensure methods of Object are also available on interface objects#1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

lostmsu merged 2 commits intopythonnet:masterfromdanabr:interface-exposes-methods-from-object

Nov 17, 2020

Merged

Ensure methods of Object are also available on interface objects#1284

lostmsu merged 2 commits intopythonnet:masterfromdanabr:interface-exposes-methods-from-object

Nov 17, 2020

Conversation

Copy link

Contributor

danabr commentedNov 17, 2020•
edited
Loading

What does this implement/fix? Explain your changes.

Allows users to callToString,GetHashCode andGetType on objects wrapped in interface objects.

Does this close any currently open issues?

Any other comments?

Checklist

Check all those that are applicable and complete.

Make sure to include one or more tests for your change
If an enhancement PR, please create docs and at best an example
Add yourself toAUTHORS
Updated theCHANGELOG

Ensure methods of Object are also available on interface objects

f5db45e

Copy link

codecov-io commentedNov 17, 2020•
edited
Loading

Codecov Report

Merging#1284 (3aae829) intomaster (2e6d12f) willnot change coverage.
The diff coverage isn/a.

@@           Coverage Diff           @@##           master    #1284   +/-   ##=======================================  Coverage   87.97%   87.97%           =======================================  Files           1        1             Lines         291      291           =======================================  Hits          256      256             Misses         35       35

Flag	Coverage Δ
setup_linux	`64.94% <ø> (-0.35%)`	⬇️
setup_windows	`74.22% <ø> (ø)`

Flags with carried forward coverage won't be shown.Click here to find out more.

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update2e6d12f...3aae829. Read thecomment docs.

filmor approved these changes

Nov 17, 2020

View reviewed changes

Copy link

Member

filmor commentedNov 17, 2020

Looks good to me, would you mind adding a Changelog entry for this?

Copy link

ContributorAuthor

I was thinking no change log entry was needed, as this was mostly a fallout from#1240 . But now I realize it was actually the case before that change as well for interface objects that had been explicitly created. I'll write something.

(Not sure what is up with the codecov though, it says coverage became worse for a file not touched by the PR?)