- Notifications
You must be signed in to change notification settings - Fork768
Remove deprecated implicit assembly loading#1277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
filmor commentedNov 11, 2020
This needs to be communicated well on the 3.0 release. |
7ae19e2 to060cccbComparelostmsu commentedNov 13, 2020
Moved one commit to a separate PR |
85c1ea4 toaeae28eCompareaeae28e toc2ce09dComparecodecov-io commentedNov 13, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #1277 +/- ##==========================================+ Coverage 87.62% 87.97% +0.34%========================================== Files 1 1 Lines 291 291 ==========================================+ Hits 255 256 +1+ Misses 36 35 -1
Flags with carried forward coverage won't be shown.Click here to find out more.
Continue to review full report at Codecov.
|
Legacy behavior:`import Company.Product.Namespace` would search for`Company.Product.Namespace.dll` .NET assmebly, load it, and import thenamespace.New behavior:User must always explicitly add assembly reference using`clr.AddReference` to `Company.Product.Namespace` prior to attemptingimport
c2ce09d to1747b42Compare
What does this implement/fix? Explain your changes.
This removes deprecated logic of implicit assembly loading
Legacy behavior:
import Company.Product.Namespacewould search forCompany.Product.Namespace.dll.NET assmebly, load it, and import the namespace.New behavior:
User must always explicitly add assembly reference using
clr.AddReferencetoCompany.Product.Namespaceprior to attempting importChecklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG