Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove deprecated implicit assembly loading#1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

lostmsu
Copy link
Member

What does this implement/fix? Explain your changes.

This removes deprecated logic of implicit assembly loading

Legacy behavior:

import Company.Product.Namespace would search forCompany.Product.Namespace.dll .NET assmebly, load it, and import the namespace.

New behavior:

User must always explicitly add assembly reference usingclr.AddReference toCompany.Product.Namespace prior to attempting import

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself toAUTHORS
  • Updated theCHANGELOG

@filmor
Copy link
Member

This needs to be communicated well on the 3.0 release.

@lostmsulostmsuforce-pushed theno-implicit-assembly-loading branch from7ae19e2 to060cccbCompareNovember 13, 2020 05:16
@lostmsu
Copy link
MemberAuthor

Moved one commit to a separate PR

@lostmsulostmsuforce-pushed theno-implicit-assembly-loading branch 2 times, most recently from85c1ea4 toaeae28eCompareNovember 13, 2020 06:17
@lostmsulostmsuforce-pushed theno-implicit-assembly-loading branch fromaeae28e toc2ce09dCompareNovember 13, 2020 06:18
@codecov-io
Copy link

codecov-io commentedNov 13, 2020
edited
Loading

Codecov Report

Merging#1277 (1747b42) intomaster (36bdb98) willincrease coverage by0.34%.
The diff coverage isn/a.

Impacted file tree graph

@@            Coverage Diff             @@##           master    #1277      +/-   ##==========================================+ Coverage   87.62%   87.97%   +0.34%==========================================  Files           1        1                Lines         291      291              ==========================================+ Hits          255      256       +1+ Misses         36       35       -1
FlagCoverage Δ
setup_linux65.29% <ø> (+0.34%)⬆️
setup_windows74.22% <ø> (+0.34%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
setup.py87.97% <0.00%> (+0.34%)⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update36bdb98...1747b42. Read thecomment docs.

Legacy behavior:`import Company.Product.Namespace` would search for`Company.Product.Namespace.dll` .NET assmebly, load it, and import thenamespace.New behavior:User must always explicitly add assembly reference using`clr.AddReference` to `Company.Product.Namespace` prior to attemptingimport
@lostmsulostmsuforce-pushed theno-implicit-assembly-loading branch fromc2ce09d to1747b42CompareNovember 13, 2020 18:04
@lostmsulostmsu merged commit2e6d12f intopythonnet:masterNov 14, 2020
@lostmsulostmsu deleted the no-implicit-assembly-loading branchNovember 14, 2020 20:04
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@filmorfilmorfilmor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@lostmsu@filmor@codecov-io

[8]ページ先頭

©2009-2025 Movatter.jp