- Notifications
You must be signed in to change notification settings - Fork768
Adds test cases for member changes during a domain reload#1275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Adds test cases for member changes during a domain reload#1275
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The tests are marked as expected failures for now.
dnfadmin commentedNov 9, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
|
codecov-io commentedNov 9, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #1275 +/- ##==========================================- Coverage 87.97% 84.53% -3.44%========================================== Files 1 1 Lines 291 291 ==========================================- Hits 256 246 -10- Misses 35 45 +10
Flags with carried forward coverage won't be shown.Click here to find out more.
Continue to review full report at Codecov.
|
Even though it tests nothing.
lostmsu left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What's the status of the time spent running these tests? Are they only enabled for supported configurations?
| <PropertyGroupCondition="$(Configuration.Contains('Debug')) AND '$(TargetFramework)'=='netstandard2.0'"> | ||
| <DebugSymbols>true</DebugSymbols> | ||
| <Optimize>false</Optimize> | ||
| <DebugType>full</DebugType> | ||
| </PropertyGroup> | ||
| <PropertyGroupCondition="$(Configuration.Contains('Release')) AND '$(TargetFramework)'=='netstandard2.0'"> | ||
| <DebugSymbols>true</DebugSymbols> | ||
| <Optimize>true</Optimize> | ||
| <DebugType>portable</DebugType> | ||
| </PropertyGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
A lot of stuff in this file seems like unnecessary clutter. Can you clean it up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It's mostly a copy from another project file. I'll see what I can remove
pythonnet.sln Outdated
| {7539EBD5-7A15-4513-BCB0-1D9BEF112BC2}.DebugWinPY3|x64.Build.0=DebugWinPY3|x64 | ||
| {7539EBD5-7A15-4513-BCB0-1D9BEF112BC2}.DebugWinPY3|x86.ActiveCfg=DebugWinPY3|x86 | ||
| {7539EBD5-7A15-4513-BCB0-1D9BEF112BC2}.DebugWinPY3|x86.Build.0=DebugWinPY3|x86 | ||
| {7539EBD5-7A15-4513-BCB0-1D9BEF112BC2}.ReleaseMono|x64.ActiveCfg=ReleaseMono|x64 | ||
| {7539EBD5-7A15-4513-BCB0-1D9BEF112BC2}.ReleaseMono|x86.ActiveCfg=ReleaseMono|x86 | ||
| {7539EBD5-7A15-4513-BCB0-1D9BEF112BC2}.ReleaseMonoPY3|x64.ActiveCfg=ReleaseMonoPY3|x64 | ||
| {7539EBD5-7A15-4513-BCB0-1D9BEF112BC2}.ReleaseMonoPY3|x86.ActiveCfg=ReleaseMonoPY3|x86 | ||
| {7539EBD5-7A15-4513-BCB0-1D9BEF112BC2}.ReleaseWin|x64.ActiveCfg=ReleaseWin|x64 | ||
| {7539EBD5-7A15-4513-BCB0-1D9BEF112BC2}.ReleaseWin|x64.Build.0=ReleaseWin|x64 | ||
| {7539EBD5-7A15-4513-BCB0-1D9BEF112BC2}.ReleaseWin|x86.ActiveCfg=ReleaseWin|x86 | ||
| {7539EBD5-7A15-4513-BCB0-1D9BEF112BC2}.ReleaseWin|x86.Build.0=ReleaseWin|x86 | ||
| {7539EBD5-7A15-4513-BCB0-1D9BEF112BC2}.ReleaseWinPY3|x64.ActiveCfg=ReleaseWinPY3|x64 | ||
| {7539EBD5-7A15-4513-BCB0-1D9BEF112BC2}.ReleaseWinPY3|x64.Build.0=ReleaseWinPY3|x64 | ||
| {7539EBD5-7A15-4513-BCB0-1D9BEF112BC2}.ReleaseWinPY3|x86.ActiveCfg=ReleaseWinPY3|x86 | ||
| {7539EBD5-7A15-4513-BCB0-1D9BEF112BC2}.ReleaseWinPY3|x86.Build.0=ReleaseWinPY3|x86 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Does the new project really need all these configurations? It might just needDebug andRelease. Solution configurations do not have to map 1:1 to project configurations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Probably not. I think it does require ax86 variant lest thexplat build doesn't run. I'll see what I can remove.
BadSingleton commentedNov 26, 2020
Good question. Each case takes ~2.2 seconds on my machine. Because they run through pytest, I haven't found a way to have them not run in netstandard builds (where the runner code is |
lostmsu commentedNov 28, 2020
Has this been completely superseded by#1287 ? |
BadSingleton commentedNov 29, 2020
We can consider it has. The original plan was to have the tests merged in before the fixes, but the fixes requires the tests.. |
Uh oh!
There was an error while loading.Please reload this page.
The tests are marked as expected failures for now.
What does this implement/fix? Explain your changes.
This adds a test harness/framework for renaming/removing members during domain reload. Actual fixes for these tests will com in other pull request(s).
Does this close any currently open issues?
This will help start addressing#1250
Any other comments?
This supersedes, in part,#1269
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG