- Notifications
You must be signed in to change notification settings - Fork749
Python 3.9#1264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Python 3.9#1264
Uh oh!
There was an error while loading.Please reload this page.
Conversation
We'll have to wait until 3.9 is available in both Travis and Appveyor. |
Waiting for |
domdfcoding commentedNov 6, 2020
Python 3.9 is now available on Travis |
- Only record structs when they are defined, not when they are declared- If a struct was only declared when a typedef was created, it won't contain its member declarations. Those have to be drawn from the recorded structs instead.- Rename internal members of AstParser to make it easier to debug
@lostmsu This is passing tests now, feel free to review. I'll backport this to 2.5. |
codecov-io commentedNov 13, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #1264 +/- ##==========================================+ Coverage 87.62% 87.97% +0.34%========================================== Files 1 1 Lines 291 291 ==========================================+ Hits 255 256 +1+ Misses 36 35 -1
Flags with carried forward coverage won't be shown.Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good, but maybe removing underscore from most members of gen_interop is a bit destructive to file's blame.
I'd also squash.
I'll clean things up a bit, but if I ever need to debug this again, I want the double-underscores already gone ;) |
* Add Python 3.9 to CI* Update AppVeyor image and always install all requirements* Add Python 3.9 interop file* Fix geninterop script and regenerate interop39.cs - Only record structs when they are defined, not when they are declared - If a struct was only declared when a typedef was created, it won't contain its member declarations. Those have to be drawn from the recorded structs instead. - Rename internal members of AstParser to make it easier to debug
retheon commentedFeb 25, 2021
Hi, it seems this branch is already merged to master but herehere it says that pythonnet does not support python 3.9. Does this page have to be updated or there is still a step I'm missing before python 3.9 is supported? |
Things are complicated, check#1389. |
What does this implement/fix? Explain your changes.
Adds Python 3.9 to CI.
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG