- Notifications
You must be signed in to change notification settings - Fork774
Make it possible to use inherited indexers#1248
Conversation
codecov-io commentedOct 7, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #1248 +/- ##======================================= Coverage 86.25% 86.25% ======================================= Files 1 1 Lines 291 291 ======================================= Hits 251 251 Misses 40 40
Flags with carried forward coverage won't be shown.Click here to find out more. Continue to review full report at Codecov.
|
lostmsu commentedOct 7, 2020
What about interfaces? |
danabr commentedOct 7, 2020
That is already handled by#1246. The calculation of whether something has an indexer or not is done the same way for classes and interfaces. It is all based on the implementation class. |
lostmsu commentedOct 7, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@danabr just to clarify. So if I have If so, I think a test for that scenario should be added to |
If a class A had indexer, and class B derived from it, Python.NET wouldnot consider class B to have any indexer.
danabr commentedOct 8, 2020
Yes. The requested test has been added. |
christabella commentedDec 24, 2020
This closes#256 |
What does this implement/fix? Explain your changes.
If a class A had indexer, and class B derived from it, Python.NET would
not consider class B to have any indexer.
Does this close any currently open issues?
No
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG