- Notifications
You must be signed in to change notification settings - Fork748
Make it possible to use inherited indexers#1248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecov-io commentedOct 7, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #1248 +/- ##======================================= Coverage 86.25% 86.25% ======================================= Files 1 1 Lines 291 291 ======================================= Hits 251 251 Misses 40 40
Flags with carried forward coverage won't be shown.Click here to find out more. Continue to review full report at Codecov.
|
What about interfaces? |
That is already handled by#1246. The calculation of whether something has an indexer or not is done the same way for classes and interfaces. It is all based on the implementation class. |
lostmsu commentedOct 7, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@danabr just to clarify. So if I have If so, I think a test for that scenario should be added to |
If a class A had indexer, and class B derived from it, Python.NET wouldnot consider class B to have any indexer.
Yes. The requested test has been added. |
This closes#256 |
What does this implement/fix? Explain your changes.
If a class A had indexer, and class B derived from it, Python.NET would
not consider class B to have any indexer.
Does this close any currently open issues?
No
Checklist
Check all those that are applicable and complete.
AUTHORS
CHANGELOG