Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Non-delegate types should not be callable#1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lostmsu merged 1 commit intopythonnet:masterfromalxnull:patch-1
Oct 5, 2020

Conversation

alxnull
Copy link
Contributor

@alxnullalxnull commentedOct 5, 2020•
edited
Loading

What does this implement/fix? Explain your changes.

As mentioned in#1180, non-delegate types should not be appear as callable. Removed theClassObject.tp_call method which seemed to be unused. Also added a test case.

Does this close any currently open issues?

Closes#1180.

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself toAUTHORS
  • Updated theCHANGELOG

@dnfadmin
Copy link

dnfadmin commentedOct 5, 2020•
edited
Loading

CLA assistant check
All CLA requirements met.

@codecov-commenter
Copy link

codecov-commenter commentedOct 5, 2020•
edited
Loading

Codecov Report

Merging#1247 intomaster willnot change coverage.
The diff coverage isn/a.

Impacted file tree graph

@@           Coverage Diff           @@##           master    #1247   +/-   ##=======================================  Coverage   86.25%   86.25%           =======================================  Files           1        1             Lines         291      291           =======================================  Hits          251      251             Misses         40       40
FlagCoverage Δ
#setup_linux64.94% <ø> (ø)
#setup_windows72.50% <ø> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update50d947f...29a9009. Read thecomment docs.

@lostmsulostmsu merged commit03cf4ac intopythonnet:masterOct 5, 2020
@lostmsu
Copy link
Member

Excellent! Thank you!

alxnull reacted with thumbs up emoji

@alxnullalxnull deleted the patch-1 branchOctober 5, 2020 20:48
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

string can't be callable
4 participants
@alxnull@dnfadmin@codecov-commenter@lostmsu
[8]ページ先頭
©2009-2025 Movatter.jp