Codecov Report

Merging#1246 intomaster willnot change coverage.
The diff coverage isn/a.

@@           Coverage Diff           @@##           master    #1246   +/-   ##=======================================  Coverage   86.25%   86.25%           =======================================  Files           1        1             Lines         291      291           =======================================  Hits          251      251             Misses         40       40

Flags with carried forward coverage won't be shown.Click here to find out more.

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update03cf4ac...12fdaab. Read thecomment docs.

I've added the two things you asked for.

The erasing of the slots is ugly. We should consider movingInitializeSlots intoManagedObject and its descendants instead, so that you would just doimpl.InitializeSlots(type), and each type could handle its own initialization.

Great, thanks!

I agree onInitializeSlots. If you'd like to work on that, you can start with a draft request demonstrating an approach for any one kind ofManagedObject (it does not have to pass tests or compile). Otherwise we'll just keep that in mind.

Overall it might make sense to move the majority ofTypeManager type creation functionality intoManagedObject and deriving classes, includingPyType construction. But we better do that along with the migration toPyType_FromSpec.