Select correct method to invoke when keyword arguments are used#1242

Merged

filmor merged 1 commit intopythonnet:masterfrom

danabr:wrong-arity-with-kwargs

Oct 1, 2020

Merged

Select correct method to invoke when keyword arguments are used#1242
filmor merged 1 commit intopythonnet:masterfrom
danabr:wrong-arity-with-kwargs

Conversation

Copy link

Contributor

danabr commentedSep 30, 2020

What does this implement/fix? Explain your changes.

If there were two methods with the same name, but with different arity,
Foo(a) andFoo(a,b), and the latter was called with a keyword
argumentsome.Foo(0, b=1),Foo(0) would be called instead of
Foo(0,1).

Does this close any currently open issues?

Fixes#1235.

Checklist

Check all those that are applicable and complete.

Make sure to include one or more tests for your change
[] If an enhancement PR, please create docs and at best an example
[] Add yourself toAUTHORS
Updated theCHANGELOG

Select correct method to invoke when keyword arguments are used

29fccdb

If there were two methods with the same name, but with different arity,`Foo(a)` and `Foo(a,b)`, and the latter was called with a keywordargument `some.Foo(0, b=1)`, `Foo(0)` would be called instead of`Foo(0,1)`.Fixespythonnet#1235.

Copy link

codecov-commenter commentedSep 30, 2020•
edited
Loading

Codecov Report

Merging#1242 intomaster willnot change coverage.
The diff coverage isn/a.

@@           Coverage Diff           @@##           master    #1242   +/-   ##=======================================  Coverage   86.25%   86.25%           =======================================  Files           1        1             Lines         291      291           =======================================  Hits          251      251             Misses         40       40

Flag	Coverage Δ
#setup_linux	`64.94% <ø> (ø)`
#setup_windows	`72.50% <ø> (ø)`

Flags with carried forward coverage won't be shown.Click here to find out more.

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updateb5ba815...29fccdb. Read thecomment docs.