Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix compiler warning#1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lostmsu merged 8 commits intopythonnet:masterfromkoubaa:compiler-warning
Sep 21, 2020
Merged

Conversation

koubaa
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commentedSep 16, 2020•
edited
Loading

Codecov Report

Merging#1226 intomaster willnot change coverage.
The diff coverage isn/a.

Impacted file tree graph

@@           Coverage Diff           @@##           master    #1226   +/-   ##=======================================  Coverage   86.25%   86.25%           =======================================  Files           1        1             Lines         291      291           =======================================  Hits          251      251             Misses         40       40
FlagCoverage Δ
#setup_linux64.94% <ø> (ø)
#setup_windows72.50% <ø> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updateef2e6b4...d5de641. Read thecomment docs.

@koubaa
Copy link
ContributorAuthor

@lostmsu please review

Copy link
Member

@filmorfilmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me, can we makePyObject.objreadonly now?

@lostmsu
Copy link
Member

@koubaa sorry, reviewed, but forgot to submit :-)

@koubaa
Copy link
ContributorAuthor

Looks good to me, can we makePyObject.objreadonly now?

It's a good thought! I tried it, but PyObject.Dispose sets it to IntPtr.Zero and that is a compiler error.

@lostmsulostmsu merged commit451fae6 intopythonnet:masterSep 21, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@filmorfilmorfilmor approved these changes

@lostmsulostmsulostmsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@koubaa@codecov-commenter@lostmsu@filmor
[8]ページ先頭
©2009-2025 Movatter.jp