NotificationsYou must be signed in to change notification settings
Fork750
Star5.1k

Bad params object[] precedence#1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

filmor merged 1 commit intopythonnet:backports-2.5fromlosttech:PR/BadParamsObjectPrecedence

Sep 14, 2020

Merged

Bad params object[] precedence#1213

filmor merged 1 commit intopythonnet:backports-2.5fromlosttech:PR/BadParamsObjectPrecedence

Sep 14, 2020

Conversation

Copy link

Member

lostmsu commentedAug 29, 2020

What does this implement/fix? Explain your changes.

A bug inArgsPrecedence caused parameters of typeobject[] to have the highest precedence, which affectedparams object[] handling, and also preferredparams object[] toparams string[] when astring argument was given.

Does this close any currently open issues?

#1211

Any other comments?

...

Checklist

Check all those that are applicable and complete.

Make sure to include one or more tests for your change
If an enhancement PR, please create docs and at best an example
Add yourself toAUTHORS
Updated theCHANGELOG

fixobject[] parameters taking precedence when should not in overlo…

6df753f

…ad resolution

Copy link

codecov-commenter commentedAug 29, 2020•
edited
Loading

Codecov Report

Merging#1213 intobackports-2.5 willnot change coverage.
The diff coverage isn/a.

@@              Coverage Diff               @@##           backports-2.5    #1213   +/-   ##==============================================  Coverage          86.53%   86.53%           ==============================================  Files                  1        1             Lines                297      297           ==============================================  Hits                 257      257             Misses                40       40

Flag	Coverage Δ
#setup_linux	`64.98% <ø> (ø)`
#setup_windows	`72.05% <ø> (ø)`

Flags with carried forward coverage won't be shown.Click here to find out more.

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update96adaaa...6df753f. Read thecomment docs.