Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Convert projects to SDK style#1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
filmor merged 12 commits intopythonnet:masterfromfilmor:sdk-style
Dec 10, 2020
Merged

Conversation

filmor
Copy link
Member

Another attempt, splitting up the conversion to a more modern style even further. This is just supposed to convert the project files and keep the existing loading for now (leaving the new loader for a separate PR based on#1109).

lostmsu reacted with thumbs up emoji
@lostmsu
Copy link
Member

Let's see the build results. If we take this, would need a tracking task for reestablishing testing on Mono.

- Convert tests to SDK style- Delete obsolete files and add common build props- Convert Runtime to SDK style and always use .NET Standard- Convert console to SDK style- Convert clrmodule to SDK style and switch to NXPorts
@filmorfilmorforce-pushed thesdk-style branch 6 times, most recently from0d3ce21 tofc6c529CompareDecember 9, 2020 17:51
@filmorfilmor requested a review fromlostmsuDecember 9, 2020 17:53
@filmorfilmor marked this pull request as ready for reviewDecember 9, 2020 17:54
@filmor
Copy link
MemberAuthor

There are two tests failing right now, both variants ofPython.EmbeddingTest.TestFinalizer.CollectBasicObject. Any idea what could be the reason?

- Build tests explicitly- Build test fixtures from the pytest call- Run tests with dotnet test- Reset solution file- Always run full test matrixNote: Newer .NET runs Mono tests as well as .NET Core tests if bothtarget frameworks are defined.
@filmorfilmorforce-pushed thesdk-style branch 2 times, most recently from5d3a26c to640b497CompareDecember 9, 2020 18:55
@filmor
Copy link
MemberAuthor

With the deactivated test, it seems to work now. Not entirely reliably, though. I had some failures in the finalisation.

@filmor
Copy link
MemberAuthor

This is done from my side.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@lostmsulostmsulostmsu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@filmor@lostmsu
[8]ページ先頭
©2009-2025 Movatter.jp