Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add syntax highlighting to Python code examples in README.rst [docs]#1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
filmor merged 7 commits intopythonnet:masterfromSFM61319:master
Aug 23, 2020
Merged

Conversation

SFM61319
Copy link
Contributor

What does this implement/fix? Explain your changes.

Added the syntax highlighting to the Python code examples inREADME.rst documentation

Does this close any currently open issues?

Yes, this solves issue#1207

Any other comments?

No.

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself toAUTHORS
  • Updated theCHANGELOG

@dnfadmin
Copy link

dnfadmin commentedAug 21, 2020
edited
Loading

CLA assistant check
All CLA requirements met.

@codecov-commenter
Copy link

codecov-commenter commentedAug 21, 2020
edited
Loading

Codecov Report

Merging#1208 intomaster willnot change coverage.
The diff coverage isn/a.

Impacted file tree graph

@@           Coverage Diff           @@##           master    #1208   +/-   ##=======================================  Coverage   86.25%   86.25%           =======================================  Files           1        1             Lines         291      291           =======================================  Hits          251      251             Misses         40       40
FlagCoverage Δ
#setup_linux64.94% <ø> (ø)
#setup_windows72.50% <ø> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.


Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update5b989cb...7fbc531. Read thecomment docs.

@lostmsu
Copy link
Member

No need for CHANGELOG entry for README.

filmor and SFM61319 reacted with thumbs up emoji

@SFM61319
Copy link
ContributorAuthor

SFM61319 commentedAug 22, 2020
edited
Loading

@lostmsu so should I remove the line fromCHANGELOG.md and create a PR again? Or I was thinking of getting this merged into the master branch and then, since I will have write powers, I can just remove that line and close that issue#1207 at the same time.

@lostmsu
Copy link
Member

@SFM61319 you will not get write powers just for getting a PR accepted. You need to revert the commit updating changelog in your branch. PR will be updated once you push this change.

@filmorfilmor merged commit29978d8 intopythonnet:masterAug 23, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@SFM61319@dnfadmin@codecov-commenter@lostmsu@filmor

[8]ページ先頭

©2009-2025 Movatter.jp