- Notifications
You must be signed in to change notification settings - Fork774
Add syntax highlighting to Python code examples in README.rst [docs]#1208
Add syntax highlighting to Python code examples in README.rst [docs]#1208filmor merged 7 commits intopythonnet:masterfromSFM61319:master
Conversation
Add Avinash Maddikonda (@SFM61319;https://github.com/SFM61319) under Contributors
Add info about updated Python syntax highlighting in README.rst's Python code examples
dnfadmin commentedAug 21, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
codecov-commenter commentedAug 21, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #1208 +/- ##======================================= Coverage 86.25% 86.25% ======================================= Files 1 1 Lines 291 291 ======================================= Hits 251 251 Misses 40 40
Flags with carried forward coverage won't be shown.Click here to find out more. Continue to review full report at Codecov.
|
lostmsu commentedAug 22, 2020
No need for CHANGELOG entry for README. |
SFM61319 commentedAug 22, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@lostmsu so should I remove the line fromCHANGELOG.md and create a PR again? Or I was thinking of getting this merged into the master branch and then, since I will have write powers, I can just remove that line and close that issue#1207 at the same time. |
lostmsu commentedAug 22, 2020
@SFM61319 you will not get write powers just for getting a PR accepted. You need to revert the commit updating changelog in your branch. PR will be updated once you push this change. |
What does this implement/fix? Explain your changes.
Added the syntax highlighting to the Python code examples inREADME.rst documentation
Does this close any currently open issues?
Yes, this solves issue#1207
Any other comments?
No.
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG