Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Added a test for finalization on shutdown#1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

lostmsu
Copy link
Member

Potential issue reported here:610d309#commitcomment-41601957

@codecov-commenter
Copy link

codecov-commenter commentedAug 21, 2020•
edited
Loading

Codecov Report

Merging#1206 intomaster willnot change coverage.
The diff coverage isn/a.

Impacted file tree graph

@@           Coverage Diff           @@##           master    #1206   +/-   ##=======================================  Coverage   86.25%   86.25%           =======================================  Files           1        1             Lines         291      291           =======================================  Hits          251      251             Misses         40       40
FlagCoverage Δ
#setup_linux64.94% <ø> (ø)
#setup_windows72.50% <ø> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update7c84b10...86a97fd. Read thecomment docs.

lostmsu referenced this pull requestAug 21, 2020
This is an attempt to make finalizer much simpler.Instead of using .NET async tasks, Py_AddPendingCall or other synchronization mechanism we simply move objects to be finalized into a ConcurrentQueue, which is periodically drained when a new PyObject is constructed.
@lostmsulostmsuforce-pushed thebugs/FinalizationOnShutdown branch from73edfdc to86a97fdCompareSeptember 20, 2020 18:48
@lostmsulostmsu changed the title[Draft] Added a test for finalization on shutdownAdded a test for finalization on shutdownSep 20, 2020
@lostmsulostmsu merged commitef2e6b4 intopythonnet:masterSep 20, 2020
@lostmsulostmsu deleted the bugs/FinalizationOnShutdown branchSeptember 20, 2020 19:58
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@lostmsu@codecov-commenter
[8]ページ先頭
©2009-2025 Movatter.jp