NotificationsYou must be signed in to change notification settings
Fork748
Star5.1k

Pybuffer#1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

lostmsu merged 8 commits intopythonnet:masterfromkoubaa:pybuffer

Aug 7, 2020

Merged

Pybuffer#1195

lostmsu merged 8 commits intopythonnet:masterfromkoubaa:pybuffer

Aug 7, 2020

Conversation

Copy link

Contributor

koubaa commentedAug 1, 2020

What does this implement/fix? Explain your changes.

Rebase ofhttps://github.com/pythonnet/pythonnet/pull/980/files
...

Does this close any currently open issues?

...

Any other comments?

...

Checklist

Check all those that are applicable and complete.

Make sure to include one or more tests for your change
If an enhancement PR, please create docs and at best an example
Add yourself toAUTHORS
Updated theCHANGELOG

thesn10 added3 commits

August 1, 2020 10:06

Add Python buffer api support

ac997a9

Update finalizer

def2cc2

Update finalizer 2

8237e87

Copy link

ContributorAuthor

koubaa commentedAug 1, 2020•
edited
Loading

@filmor I took this one. After rebasing I just had to bring back a property on the runtime which we removed. It used to be public but I brought it back as internal.

bring back pyversionnumber but leave it internal

edd849f

Copy link

codecov-commenter commentedAug 1, 2020•
edited
Loading

Codecov Report

Merging#1195 intomaster willnot change coverage.
The diff coverage isn/a.

@@           Coverage Diff           @@##           master    #1195   +/-   ##=======================================  Coverage   86.25%   86.25%           =======================================  Files           1        1             Lines         291      291           =======================================  Hits          251      251             Misses         40       40

Flag	Coverage Δ
#setup_linux	`64.94% <ø> (ø)`
#setup_windows	`72.50% <ø> (ø)`

Flags with carried forward coverage won't be shown.Click here to find out more.

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatef72a16d...0ed417c. Read thecomment docs.

filmor reviewed

Aug 1, 2020

View reviewed changes

src/runtime/runtime.cs Outdated

		//"3.0a5+ (py3k:63103M, May 12 2008, 00:53:55) \n[GCC 4.2.3]"

		//we only support python 3 so we just need to check the third character
		return 30 + Convert.ToInt32(versionString[2]);