fixed crash due to a decref of a borrowed reference in params array handling#1163

Merged

filmor merged 1 commit intopythonnet:masterfrom

losttech:PR/ParamsArrayRefcount

Jun 18, 2020

Merged

fixed crash due to a decref of a borrowed reference in params array handling#1163
filmor merged 1 commit intopythonnet:masterfrom
losttech:PR/ParamsArrayRefcount

Conversation

Copy link

Member

lostmsu commentedJun 17, 2020

What does this implement/fix? Explain your changes.

item is a return value ofPyTuple_GetItem which returns borrowed reference.

Hence it should not have been decref'ed

fixed crash due to unnecessary decref of a borrowed reference in para…

d87d033

…ms array handling

lostmsu requested a review fromfilmor

June 17, 2020 22:56

lostmsu mentioned this pull request

Jun 17, 2020

Bad refcounting in HandleParamsArray (2.x backport)#1164

Closed

Copy link

codecov-commenter commentedJun 17, 2020•
edited
Loading

Codecov Report

Merging#1163 intomaster willnot change coverage.
The diff coverage isn/a.

@@           Coverage Diff           @@##           master    #1163   +/-   ##=======================================  Coverage   86.53%   86.53%           =======================================  Files           1        1             Lines         297      297           =======================================  Hits          257      257             Misses         40       40

Flag	Coverage Δ
#setup_linux	`64.98% <ø> (ø)`
#setup_windows	`72.05% <ø> (ø)`

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update742463e...d87d033. Read thecomment docs.