- Notifications
You must be signed in to change notification settings - Fork774
Increase ob's ref count in tp_repr to avoid accidental free#1160
Increase ob's ref count in tp_repr to avoid accidental free#1160lostmsu merged 1 commit intopythonnet:masterfromDanBarzilian:PR/fix-tp_repr-bug
Conversation
dnfadmin commentedJun 17, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
codecov-commenter commentedJun 17, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #1160 +/- ##======================================= Coverage 86.53% 86.53% ======================================= Files 1 1 Lines 297 297 ======================================= Hits 257 257 Misses 40 40
Continue to review full report at Codecov.
|
filmor commentedJun 17, 2020
@lostmsu We should probably do a point-release for this, agree? |
lostmsu commentedJun 17, 2020
@filmor I have another one too in the recent params array change. |
lostmsu commentedJun 17, 2020
BTW,@DanBarzilian , a personal thank you 10x! This finding and the fix for it just saved me after 3 workdays of chasing a semi-random segfault in tests. I don't know how much time I would have wasted trying to find this. Funnily, while searching for (apparently) this issue, I stumbled and fixed another less impacting one:losttech@74e7d62 |
lostmsu commentedJun 17, 2020
koubaa commentedJun 19, 2020
@lostmsu now it explains why the CI has been unreliable recently. Big whoops for missing this and yes more evidence to use Reference types. Good catch@DanBarzilian |
What does this implement/fix? Explain your changes.
Fix incorrect dereferencing wrapper object in tp_repr function, which causes the program to crash.
Does this close any currently open issues?
...
Any other comments?
...
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG