Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Added IsNone() and GetPyNone()#1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
filmor merged 4 commits intopythonnet:masterfromhenon:net_framework
May 11, 2020
Merged

Conversation

henon
Copy link
Contributor

@henonhenon commentedMay 10, 2020•
edited
Loading

What does this implement/fix? Explain your changes.

IsNone() and GetPyNone() were needed for Numpy.NET to be able to find out if a PyObject is none.

Does this close any currently open issues?

No.

Any other comments?

These are in use for a long time now, I just now figured out how to PR them. I'll commit the necessary things from the checklist below.

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself toAUTHORS
  • Updated theCHANGELOG

@dnfclas
Copy link

dnfclas commentedMay 10, 2020•
edited
Loading

CLA assistant check
All CLA requirements met.

@henon
Copy link
ContributorAuthor

I have no idea how to add a test and the change is so small that it doesn't really need documentation.

@filmor
Copy link
Member

I completely get theIsNone, but what do you need theGetPyNone for? It's a bit arbitrary here, isn't it?

@lostmsu
Copy link
Member

@filmor re:GetPyNone it is actually useful. I have it in my branch too. That's the easiest way to passNone.

Though as a static property (and I don't see why it should not be a property).

@henon
Copy link
ContributorAuthor

You might wanna squash this PR into a single commit.

lostmsu reacted with thumbs up emoji

Copy link
Member

@lostmsulostmsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good! Thank you!

@filmorfilmor merged commit960286d intopythonnet:masterMay 11, 2020
@filmor
Copy link
Member

Thank you :)

AlexCatarino pushed a commit to QuantConnect/pythonnet that referenced this pull requestJun 29, 2020
* Add `PyObject.IsNone()`* Add `Runtime.None` which returns a reference to `None` as a `PyObject` to be able to pass it into Python from .NET
@henonhenon deleted the net_framework branchJuly 31, 2020 14:48
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@lostmsulostmsulostmsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@henon@dnfclas@filmor@lostmsu
[8]ページ先頭
©2009-2025 Movatter.jp