NotificationsYou must be signed in to change notification settings
Fork749
Star5.1k

name and signature for .NET methods#1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

lostmsu merged 1 commit intopythonnet:masterfromlosttech:PR/Inspect

Oct 1, 2021

Merged

name and signature for .NET methods#1133

lostmsu merged 1 commit intopythonnet:masterfromlosttech:PR/Inspect

Oct 1, 2021

Conversation

Copy link

Member

lostmsu commentedMay 4, 2020

What does this implement/fix? Explain your changes.

This implements__name__ and__signature__ Python members for reflected .NET methods, that enables them to be analyzed withinspect module.

Does this close any currently open issues?

N/A

Any other comments?

Some Python libraries validate passed callables by usinginspect module. This makes it possible for .NET methods to pass this kind of validation.

Checklist

Check all those that are applicable and complete.

Make sure to include one or more tests for your change
If an enhancement PR, please create docs and at best an example
Add yourself toAUTHORS
Updated theCHANGELOG

lostmsu force-pushed thePR/Inspect branch from10406cd to94b461bCompare

May 14, 2020 05:04

Copy link

codecov-io commentedMay 14, 2020•
edited
Loading

Codecov Report

Merging#1133 intomaster willnot change coverage.
The diff coverage isn/a.

@@           Coverage Diff           @@##           master    #1133   +/-   ##=======================================  Coverage   86.66%   86.66%           =======================================  Files           1        1             Lines         300      300           =======================================  Hits          260      260             Misses         40       40

Flag	Coverage Δ
#setup_linux	`65.33% <ø> (ø)`
#setup_windows	`72.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updated8f5ab0...da968d0. Read thecomment docs.

filmor reviewed

May 14, 2020

View reviewed changes

src/runtime/methodbinding.cs OutdatedShow resolvedHide resolved

lostmsu force-pushed thePR/Inspect branch from94b461b toda968d0Compare

May 14, 2020 19:58

Copy link

Member

filmor commentedMay 16, 2020

@lostmsu Can you update this with the latestmaster? Should this go into 2.5?

lostmsu force-pushed thePR/Inspect branch fromda968d0 to00e5ddbCompare

May 16, 2020 20:57

Copy link

MemberAuthor

lostmsu commentedMay 16, 2020

@filmor this is not a breaking change, so as you wish.

filmor added this to the3.0.0 milestone

May 17, 2020

Copy link

Member

filmor commentedMay 17, 2020

After looking at it a bit, I'd rather merge this later (maybe backporting to 2.5) because relying on standard library modules is always a bit tricky (cf. theplatform fiasco... ;)).

Copy link

codecov-commenter commentedMay 29, 2020•
edited
Loading

Codecov Report

Merging#1133 intomaster willdecrease coverage by0.27%.
The diff coverage isn/a.

@@            Coverage Diff             @@##           master    #1133      +/-   ##==========================================- Coverage   86.53%   86.25%   -0.28%==========================================  Files           1        1                Lines         297      291       -6     ==========================================- Hits          257      251       -6  Misses         40       40

Flag	Coverage Δ
#setup_linux	`64.94% <ø> (-0.04%)`	⬇️
#setup_windows	`72.50% <ø> (+0.45%)`	⬆️

Impacted Files	Coverage Δ
setup.py	`86.25% <0.00%> (-0.28%)`	⬇️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update742463e...e104143. Read thecomment docs.