To be honest, I would prefer an explicitNewReference.Borrow() method due to "explicit is better than implicit" motto. The only problem with implicit conversion that I see isnew PyObject(newRef) will call an extra incref implicitly as opposed tonewRef.MoveToPyObject(), and will go unnoticed.

Another thing to consider is having anull-check in the conversion. E.g. should we throwNullReferenceException ifNewReference isnull?

Does this close any currently open issues?

Related to#1087

Checklist

Check all those that are applicable and complete.

Make sure to include one or more tests for your change
If an enhancement PR, please create docs and at best an example

allow borrowing from NewReference

0f03624

implemented as an implicit conversion

lostmsu mentioned this pull request

Mar 11, 2020

Add PyHandle#1087

Closed

4 tasks

Copy link

codecov-io commentedMar 11, 2020•
edited
Loading

Codecov Report

Merging#1088 intomaster willnot change coverage by%.
The diff coverage isn/a.

@@           Coverage Diff           @@##           master    #1088   +/-   ##=======================================  Coverage   86.75%   86.75%           =======================================  Files           1        1             Lines         302      302           =======================================  Hits          262      262             Misses         40       40

Flag	Coverage Δ
#setup_linux	`65.56% <ø> (ø)`
#setup_windows	`71.52% <ø> (ø)`

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updated145ab1...0f03624. Read thecomment docs.