PyObjects constructed for__exit__ method referenced existing Python objects without increasing refcount appropriately, which could lead to double-free.

Does this close any currently open issues?

Not sure, but this issue might have been one of the possible causes for#1050

fixed reference counting for exception objects in Py.With

caaa798

PyObject(s) constructed for __exit__ method referenced existing Python objects without increasing refcount appropriately, which could lead to double-free.

Copy link

codecov-io commentedFeb 26, 2020•
edited
Loading

Codecov Report

Merging#1062 intomaster willincrease coverage by0.33%.
The diff coverage isn/a.

@@            Coverage Diff             @@##           master    #1062      +/-   ##==========================================+ Coverage   86.42%   86.75%   +0.33%==========================================  Files           1        1                Lines         302      302              ==========================================+ Hits          261      262       +1+ Misses         41       40       -1

Flag	Coverage Δ
#setup_linux	`65.56% <ø> (+0.66%)`	⬆️
#setup_windows	`71.52% <ø> (ø)`	⬆️

Impacted Files	Coverage Δ
setup.py	`86.75% <0%> (+0.33%)`	⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update22735f8...caaa798. Read thecomment docs.

filmor approved these changes

Feb 26, 2020

View reviewed changes

filmor merged commit6c03245 intopythonnet:master

Feb 26, 2020

This was referencedFeb 26, 2020

Codecs: customize set of Py<->C# conversions via PyObjectConversions#1022

Merged

AppVeyor tests failing with timeout#1050

Closed

lostmsu deleted the bugs/1050 branch

February 27, 2020 21:40

Copy link

Contributor

alexhelms commentedMar 6, 2020

I just wanted to comment on here to tell you that I ran into this issue and this PR was the root cause. We had some python exceptions being fired within aPy.With and it was causing memory exceptions and blowing up.

Thanks!

AlexCatarino pushed a commit to QuantConnect/pythonnet that referenced this pull request

Jun 29, 2020

fixed reference counting for exception objects in Py.With (pythonnet#…

02c400a

…1062)PyObject(s) constructed for __exit__ method referenced existing Python objects without increasing refcount appropriately, which could lead to double-free.

lostmsu mentioned this pull request

Jul 30, 2020

Should Python.Runtime.Py.With use Runtime.None instead of new PyObject(Runtime.PyNone)?#1192

Closed