Commitf121c44

dse

authored and

committed

Interop fix for Py_ssize_t methods (it's produces problems only on NetCoreApp 2.0).

1 parent784190a commitf121c44Copy full SHA for f121c44

File tree

+226

-50

lines changed

+226

-50

lines changed

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,7 @@ This document follows the conventions laid out in [Keep a CHANGELOG][].`
`28`	`28`	`- Fixed Visual Studio 2017 compat ([#434][i434]) for setup.py`
`29`	`29`	`- Fixed crashes when integrating pythonnet in Unity3d ([#714][i714]),`
`30`	`30`	`related to unloading the Application Domain`
	`31`	`+- Fixed interop methods with Py_ssize_t. NetCoreApp 2.0 is more sensitive than net40 and requires this fix. ([#531][p531])`
`31`	`32`	`- Fixed crash on exit of the Python interpreter if a python class`
`32`	`33`	derived from a .NET class has a`__namespace__` or`__assembly__`
`33`	`34`	`attribute ([#481][i481])`
`@@ -688,3 +689,4 @@ This document follows the conventions laid out in [Keep a CHANGELOG][].`
`688`	`689`	`[p163]:https://github.com/pythonnet/pythonnet/pull/163`
`689`	`690`	`[p625]:https://github.com/pythonnet/pythonnet/pull/625`
`690`	`691`	`[i131]:https://github.com/pythonnet/pythonnet/issues/131`
	`692`	`+[p531]:https://github.com/pythonnet/pythonnet/pull/531`

Lines changed: 2 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -69,10 +69,8 @@ public void TestRepeat()`
`69`	`69`	`PyObjectactual=t1.Repeat(3);`
`70`	`70`	`Assert.AreEqual("FooFooFoo",actual.ToString());`
`71`	`71`
`72`		`-// On 32 bit system this argument should be int, but on the 64 bit system this should be long value.`
`73`		`-// This works on the Framework 4.0 accidentally, it should produce out of memory!`
`74`		`-// actual = t1.Repeat(-3);`
`75`		`-// Assert.AreEqual("", actual.ToString());`
	`72`	`+actual=t1.Repeat(-3);`
	`73`	`+Assert.AreEqual("",actual.ToString());`
`76`	`74`	`}`
`77`	`75`
`78`	`76`	`[Test]`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -276,7 +276,7 @@ public static void SetError(Exception e)`
`276`	`276`	`/// </remarks>`
`277`	`277`	`publicstaticboolErrorOccurred()`
`278`	`278`	`{`
`279`		`-returnRuntime.PyErr_Occurred()!=0;`
	`279`	`+returnRuntime.PyErr_Occurred()!=IntPtr.Zero;`
`280`	`280`	`}`
`281`	`281`
`282`	`282`	`/// <summary>`

Comments

(0)