Commitee6a828

authored

Remove superfluous Incref

Also drop comment on the type check.If `PyCell_Set` is not called with a cell it will raise an exception, which is perfectly valid here.

1 parent82b8fdb commitee6a828Copy full SHA for ee6a828

File tree

-5

lines changed

-5

lines changed

Lines changed: 1 addition & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -284,11 +284,7 @@ internal static IntPtr CreateSubType(IntPtr py_name, IntPtr py_base_type, IntPtr`
`284`	`284`	`IntPtrcell=Runtime.PyDict_GetItemString(cls_dict,"__classcell__");`
`285`	`285`	`if(cell!=IntPtr.Zero)`
`286`	`286`	`{`
`287`		`-// if (Runtime.PyObject_TypeCheck(cell, Runtime.PyCellType))`
`288`		`-{`
`289`		`-Runtime.XIncref(cell);`
`290`		`-Runtime.PyCell_Set(cell,py_type);`
`291`		`-}`
	`287`	`+Runtime.PyCell_Set(cell,py_type);`
`292`	`288`	`Runtime.PyDict_DelItemString(cls_dict,"__classcell__");`
`293`	`289`	`}`
`294`	`290`

Comments

(0)