Commitd8b0200

authored

fixed crash due to unnecessary decref of a borrowed reference in params array handling (#1163)

1 parent742463e commitd8b0200Copy full SHA for d8b0200

File tree

-5

lines changed

-5

lines changed

Lines changed: 1 addition & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -372,7 +372,7 @@ internal Binding Bind(IntPtr inst, IntPtr args, IntPtr kw, MethodBase info, Meth`
`372`	`372`	`staticIntPtrHandleParamsArray(IntPtrargs,intarrayStart,intpyArgCount,outboolisNewReference)`
`373`	`373`	`{`
`374`	`374`	`isNewReference=false;`
`375`		`-IntPtrop;`
	`375`	`+IntPtrop;`
`376`	`376`	`// for a params method, we may have a sequence or single/multiple items`
`377`	`377`	`// here we look to see if the item at the paramIndex is there or not`
`378`	`378`	`// and then if it is a sequence itself.`
`@@ -390,10 +390,6 @@ static IntPtr HandleParamsArray(IntPtr args, int arrayStart, int pyArgCount, out`
`390`	`390`	`{`
`391`	`391`	`isNewReference=true;`
`392`	`392`	`op=Runtime.PyTuple_GetSlice(args,arrayStart,pyArgCount);`
`393`		`-if(item!=IntPtr.Zero)`
`394`		`-{`
`395`		`-Runtime.XDecref(item);`
`396`		`-}`
`397`	`393`	`}`
`398`	`394`	`}`
`399`	`395`	`else`

Comments

(0)