Commitd86bf3c

authored

ParameterInfo.Name needs to be checked for null before usage (#1375)

This occured in trying to use F# code from Python. As the `.Name` propertyreturns `null`, `ContainsKey` fails.Related documentation:https://docs.microsoft.com/en-us/dotnet/api/system.reflection.parameterinfo.name

1 parent1afae4c commitd86bf3cCopy full SHA for d86bf3c

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -56,6 +56,7 @@ or the DLL must be loaded in advance. This must be done before calling any other`
`56`	`56`	-`import` may now raise errors with more detail than "No module named X"
`57`	`57`	- Exception stacktraces on`PythonException.StackTrace` are now properly formatted
`58`	`58`	`- Providing an invalid type parameter to a generic type or method produces a helpful Python error`
	`59`	`+- Empty parameter names (as can be generated from F#) do not cause crashes`
`59`	`60`
`60`	`61`	`###Removed`
`61`	`62`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -622,7 +622,7 @@ static object[] TryConvertArguments(ParameterInfo[] pi, bool paramsArray,`
`622`	`622`	`for(intparamIndex=0;paramIndex<pi.Length;paramIndex++)`
`623`	`623`	`{`
`624`	`624`	`varparameter=pi[paramIndex];`
`625`		`-boolhasNamedParam=kwargDict.ContainsKey(parameter.Name);`
	`625`	`+boolhasNamedParam=parameter.Name!=null?kwargDict.ContainsKey(parameter.Name):false;`
`626`	`626`	`boolisNewReference=false;`
`627`	`627`
`628`	`628`	`if(paramIndex>=pyArgCount&&!(hasNamedParam\|\|(paramsArray&&paramIndex==arrayStart)))`

Comments

(0)