Commitb85104b

authored and

committed

Fixed crash due to unnecessary decref of a borrowed reference in params array handling (#1163)

1 parent8e8f205 commitb85104bCopy full SHA for b85104b

File tree

-6

lines changed

-6

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,8 @@ This document follows the conventions laid out in [Keep a CHANGELOG][].`
`13`	`13`
`14`	`14`	`###Fixed`
`15`	`15`
`16`		`-- Fix incorrect dereference of wrapper object in tp_repr, which may result in a program crash`
	`16`	+- Fix incorrect dereference of wrapper object in`tp_repr`, which may result in a program crash
	`17`	`+- Fix incorrect dereference in params array handling`
`17`	`18`
`18`	`19`	`##[2.5.0][] - 2020-06-14`
`19`	`20`

Lines changed: 1 addition & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -372,7 +372,7 @@ internal Binding Bind(IntPtr inst, IntPtr args, IntPtr kw, MethodBase info, Meth`
`372`	`372`	`staticIntPtrHandleParamsArray(IntPtrargs,intarrayStart,intpyArgCount,outboolisNewReference)`
`373`	`373`	`{`
`374`	`374`	`isNewReference=false;`
`375`		`-IntPtrop;`
	`375`	`+IntPtrop;`
`376`	`376`	`// for a params method, we may have a sequence or single/multiple items`
`377`	`377`	`// here we look to see if the item at the paramIndex is there or not`
`378`	`378`	`// and then if it is a sequence itself.`
`@@ -390,10 +390,6 @@ static IntPtr HandleParamsArray(IntPtr args, int arrayStart, int pyArgCount, out`
`390`	`390`	`{`
`391`	`391`	`isNewReference=true;`
`392`	`392`	`op=Runtime.PyTuple_GetSlice(args,arrayStart,pyArgCount);`
`393`		`-if(item!=IntPtr.Zero)`
`394`		`-{`
`395`		`-Runtime.XDecref(item);`
`396`		`-}`
`397`	`393`	`}`
`398`	`394`	`}`
`399`	`395`	`else`

Comments

(0)