Commita6c55d4

committed

relax performance targets to ~10%, improve perf failure message

1 parent340a6d1 commita6c55d4Copy full SHA for a6c55d4

File tree

+11

-2

lines changed

+11

-2

lines changed

Lines changed: 11 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -30,14 +30,14 @@ public void SetUp()`
`30`	`30`	`publicvoidReadInt64Property()`
`31`	`31`	`{`
`32`	`32`	`doubleoptimisticPerfRatio=GetOptimisticPerfRatio(this.summary.Reports);`
`33`		`-Assert.LessOrEqual(optimisticPerfRatio,0.68);`
	`33`	`+AssertPerformanceIsBetterOrSame(optimisticPerfRatio,target:0.66);`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`[Test]`
`37`	`37`	`publicvoidWriteInt64Property()`
`38`	`38`	`{`
`39`	`39`	`doubleoptimisticPerfRatio=GetOptimisticPerfRatio(this.summary.Reports);`
`40`		`-Assert.LessOrEqual(optimisticPerfRatio,0.67);`
	`40`	`+AssertPerformanceIsBetterOrSame(optimisticPerfRatio,target:0.64);`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`staticdoubleGetOptimisticPerfRatio(`
`@@ -61,5 +61,14 @@ static double GetOptimisticPerfRatio(`
`61`	`61`	`}`
`62`	`62`
`63`	`63`	`publicstaticstringDeploymentRoot=>Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location);`
	`64`	`+`
	`65`	`+publicstaticvoidAssertPerformanceIsBetterOrSame(`
	`66`	`+doubleactual,doubletarget,`
	`67`	`+doublewiggleRoom=1.1,[CallerMemberName]stringtestName=null){`
	`68`	`+doublethreshold=target*wiggleRoom;`
	`69`	`+Assert.LessOrEqual(actual,threshold,`
	`70`	`+$"{testName}:{actual:F3} >{threshold:F3} (target:{target:F3})"`
	`71`	`++": perf result is higher than the failure threshold.");`
	`72`	`+}`
`64`	`73`	`}`
`65`	`74`	`}`

Comments

(0)