Commit3362cf8

authored

GILState.Dispose is safe to be called multiple times (#1037)

* GILState.Dispose is safe to be called multiple times* test multiple class to GILState.Dispose

1 parent3b938a5 commit3362cf8Copy full SHA for 3362cf8

File tree

+26

-1

lines changed

+26

-1

lines changed

Lines changed: 21 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,21 @@`
	`1`	`+namespacePython.EmbeddingTest`
	`2`	`+{`
	`3`	`+usingNUnit.Framework;`
	`4`	`+usingPython.Runtime;`
	`5`	`+`
	`6`	`+publicclassTestGILState`
	`7`	`+{`
	`8`	`+/// <summary>`
	`9`	`+/// Ensure, that calling <see cref="Py.GILState.Dispose"/> multiple times is safe`
	`10`	`+/// </summary>`
	`11`	`+[Test]`
	`12`	`+publicvoidCanDisposeMultipleTimes()`
	`13`	`+{`
	`14`	`+using(vargilState=Py.GIL())`
	`15`	`+{`
	`16`	`+for(inti=0;i<50;i++)`
	`17`	`+gilState.Dispose();`
	`18`	`+}`
	`19`	`+}`
	`20`	`+}`
	`21`	`+}`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -643,7 +643,8 @@ public static PyScope CreateScope(string name)`
`643`	`643`
`644`	`644`	`publicclassGILState:IDisposable`
`645`	`645`	`{`
`646`		`-privateIntPtrstate;`
	`646`	`+privatereadonlyIntPtrstate;`
	`647`	`+privateboolisDisposed;`
`647`	`648`
`648`	`649`	`internalGILState()`
`649`	`650`	`{`
`@@ -652,8 +653,11 @@ internal GILState()`
`652`	`653`
`653`	`654`	`publicvoidDispose()`
`654`	`655`	`{`
	`656`	`+if(this.isDisposed)return;`
	`657`	`+`
`655`	`658`	`PythonEngine.ReleaseLock(state);`
`656`	`659`	`GC.SuppressFinalize(this);`
	`660`	`+this.isDisposed=true;`
`657`	`661`	`}`
`658`	`662`
`659`	`663`	`~GILState()`

Comments

(0)