NotificationsYou must be signed in to change notification settings
Fork768
Star5.4k

Commit07f65c7

committed

Copy potential BOM to the output of PyString_FromString

The documentation of the used `PyUnicode_DecodeUTF16` states that notpassing `*byteorder` or passing a 0 results in the first two bytes, ifthey are the BOM (U+FEFF, zero-width no-break space), to be interpretedand skipped, which is incorrect when we convert a known "non BOM"string, which all strings from C# are.

1 parent161a7e7 commit07f65c7Copy full SHA for 07f65c7

File tree

1 file changed

-1

lines changed

src/runtime
- Runtime.cs

1 file changed

-1

lines changed

`‎src/runtime/Runtime.cs‎`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1252,12 +1252,14 @@ internal static bool PyString_CheckExact(BorrowedReference ob)`
`1252`	`1252`
`1253`	`1253`	`internalstaticNewReferencePyString_FromString(stringvalue)`
`1254`	`1254`	`{`
	`1255`	`+intbyteorder=BitConverter.IsLittleEndian?-1:1;`
	`1256`	`+int*byteorderPtr=&byteorder;`
`1255`	`1257`	`fixed(char*ptr=value)`
`1256`	`1258`	`returnDelegates.PyUnicode_DecodeUTF16(`
`1257`	`1259`	`(IntPtr)ptr,`
`1258`	`1260`	`value.Length*sizeof(Char),`
`1259`	`1261`	`IntPtr.Zero,`
`1260`		`-IntPtr.Zero`
	`1262`	`+(IntPtr)byteorderPtr`
`1261`	`1263`	`);`
`1262`	`1264`	`}`
`1263`	`1265`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit07f65c7

File tree

1 file changed

1 file changed

`‎src/runtime/Runtime.cs‎`

0 commit comments