- Notifications
You must be signed in to change notification settings - Fork0
Sourcery refactored main branch#1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| else: | ||
| result += temp | ||
| exclude += [x["objectID"] for x in temp] | ||
| count += 1 | ||
| result += temp | ||
| exclude += [x["objectID"] for x in temp] | ||
| count += 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Functionmain refactored with the following changes:
- Remove unnecessary else after guard condition (
remove-unnecessary-else)
| "params":f'query=&hitsPerPage=1000&facetFilters=[["city.work_country_name:Indonesia"]]', | ||
| "params": 'query=&hitsPerPage=1000&facetFilters=[["city.work_country_name:Indonesia"]]', | ||
| } | ||
| ] | ||
| } | ||
| if not filter_object_id: | ||
| pass | ||
| else: | ||
| if filter_object_id: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Functionfetch refactored with the following changes:
- Replace f-string with no interpolated values with string (
remove-redundant-fstring) - Swap if/else to remove empty if body (
remove-pass-body) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
Sourcery Code Quality Report✅ Merging this PR willincrease code quality in the affected files by1.11%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentationhere for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help usimprove this quality report! |
Branch
mainrefactored bySourcery.If you're happy with these changes, merge this Pull Request using theSquash and merge strategy.
See our documentationhere.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run:Help usimprove this pull request!