- Notifications
You must be signed in to change notification settings - Fork52
Fix return type for name property in Credentials class.#352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
7278672 toda7fdc3Comparejborean93 commentedFeb 17, 2025
Hey sorry the CI workers were a bit old so I had to update them in#353 to get CI passing. Would you be able to rebase this PR so it runs with the latest changes before I merge it in? |
…est checks.Signed-off-by: Aleksey Kondratov <drfobos91@mail.ru>
DrFobos commentedFeb 18, 2025
Sure, no problem. |
jborean93 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for fixing this.
52bd8e9 intopythongssapi:mainUh oh!
There was an error while loading.Please reload this page.
It seems like type annotation forname property ingssapi.creds.Credentials class should be gssapi.names.Name rather than gssapi.raw.names.Name.
Because it explicitly casts ingssapi.creds.Credentials.inquire.
Change return type and add checks into tests.