- Notifications
You must be signed in to change notification settings - Fork52
Bump version to 1.8.1 with Python 3.7 requires#300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
webknjaz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Don't forget to drop the trove classifier too.
This update bumps the `python_requires` to be `>=3.7` as the sdist buildrequires PEP 517 support that is somewhat only guaranteed with the pipthat was shipped with Python 3.7 or greater. Since 3.6 has been end oflife since December 2021 and the remaining Linux distributions thatstill use it have system provided packages this shouldn't be a surprise.Also use CentOS 9 Stream in the CI tests to test this on an actualRHEL-ish host on the version of Python actually supported.Signed-off-by: Jordan Borean <jborean93@gmail.com>
ContributorAuthor
jborean93 commentedAug 15, 2022
Thanks, I forgot about those, they've been dropped. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update bumps the
python_requiresto be>=3.7as the sdist buildrequires PEP 517 support that is somewhat only guaranteed with the pip
that was shipped with Python 3.7 or greater. Since 3.6 has been end of
life since December 2021 and the remaining Linux distributions that
still use it have system provided packages this shouldn't be a surprise.
Fixes#299
Signed-off-by: Jordan Boreanjborean93@gmail.com