- Notifications
You must be signed in to change notification settings - Fork52
Add Python type annotation#284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
fbd623c to2cc6416CompareSigned-off-by: Jordan Borean <jborean93@gmail.com>
Contributor
simo5 commentedFeb 15, 2022
LGTM |
simo5 approved these changesFeb 15, 2022
Contributor
simo5 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this is a mess of a change, but also very beneficial, I'll steal this stuff.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Adds type annotations to the library for better type analysis and IDE integration with this library. Currently the
gssapi.rawcontents have been annotated with.pyifiles. Using a separate file is quite useful for C extensions as an IDE can easily inspect what functions are meant to be available, their types, and doc strings without having the extension actually compiled and installed. Because of this all the docstrings have been moved out of the Cython pyx files into their respective pyi files. The Sphinx doc generator has also been updated to support this.The next step is to annotate the high level- donegssapipackage and enable some mypy tests for CI to ensure this library is valid.Signed-off-by: Jordan Boreanjborean93@gmail.com