- Notifications
You must be signed in to change notification settings - Fork52
Add macOS wheels and simplify release process#267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
8f2654d tofe405b5CompareConverts the existing GitHub action files to YAML to reduce some of thequotes, lines, and support comments. Changes the release process tobuild the sdist first and then the wheels are built from that sdist.Also adds macOS wheels to the publishing process.Signed-off-by: Jordan Borean <jborean93@gmail.com>
jborean93 commentedOct 6, 2021
The wheels and sdist to test from this release process. Will need to manually verify this still works on Windows and macOS before merging this PR. The artifact is fromhttps://github.com/pythongssapi/python-gssapi/pull/267/checks?check_run_id=3811298187 which essentially ran the |
jborean93 commentedOct 6, 2021
@aiudirog if you get a chance it would be great if you could validate some of the Windows wheels inartifact.zip. This PR changes the build process to usecibuildwheel and while I don't forsee any problems with the changes it would be nice to have that validated by someone who uses the library. I've done a comparison on some of the |
jborean93 commentedOct 6, 2021
I've manually tested the I feel confident the macOS wheels here will be fine going forward. |
aiudirog commentedOct 6, 2021
This looks great! Can we do an RC release (either 1.8.0rc1 or 1.7.1rc1, not sure where we are semver speaking) so the wheels get built this way and uploaded to PyPI but not set as the default for the public yet? Then I can run some tests on them exactly as they will be built. |
jborean93 commentedOct 6, 2021
That's a good idea, I'll probably settle on |
This changes the github workflows to an actual yaml definition (my personal preference over the quoting hell that is json).
This now usescibuildwheel to build the Windows and macOS wheels instead of it being a manual step. The release process on PyPI is now one step instead of the manual twine call.
Fixes#230
Signed-off-by: Jordan Boreanjborean93@gmail.com