Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add macOS wheels and simplify release process#267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jborean93 merged 1 commit intopythongssapi:mainfromjborean93:macOS-wheel
Oct 6, 2021

Conversation

@jborean93
Copy link
Contributor

This changes the github workflows to an actual yaml definition (my personal preference over the quoting hell that is json).

This now usescibuildwheel to build the Windows and macOS wheels instead of it being a manual step. The release process on PyPI is now one step instead of the manual twine call.

Fixes#230

Signed-off-by: Jordan Boreanjborean93@gmail.com

@jborean93jborean93force-pushed themacOS-wheel branch 3 times, most recently from8f2654d tofe405b5CompareOctober 6, 2021 05:31
Converts the existing GitHub action files to YAML to reduce some of thequotes, lines, and support comments. Changes the release process tobuild the sdist first and then the wheels are built from that sdist.Also adds macOS wheels to the publishing process.Signed-off-by: Jordan Borean <jborean93@gmail.com>
@jborean93
Copy link
ContributorAuthor

The wheels and sdist to test from this release process. Will need to manually verify this still works on Windows and macOS before merging this PR. The artifact is fromhttps://github.com/pythongssapi/python-gssapi/pull/267/checks?check_run_id=3811298187 which essentially ran therelease.yml workflow just without the publishing steps.

artifact.zip

@jborean93jborean93 marked this pull request as ready for reviewOctober 6, 2021 11:35
@jborean93
Copy link
ContributorAuthor

@aiudirog if you get a chance it would be great if you could validate some of the Windows wheels inartifact.zip. This PR changes the build process to usecibuildwheel and while I don't forsee any problems with the changes it would be nice to have that validated by someone who uses the library.

I've done a comparison on some of the.pyd files in the cibuildwheel wheels and ones from the latest release on PyPI and I couldn't find any linking differences which is a good sign. I was also able to install and import them just fine with Python 3.9 but that was a very basic sanity check.

@jborean93
Copy link
ContributorAuthor

I've manually tested themacOS wheels on an M1 Mac Mini and the wheels generated install and import correctly on both thearm64 andx86_64 Python installs I have there. Usingotool I can validate the dynamic links are the same with a manually built wheel from the sdist that currently occurs withpip install gssapi right now.

I feel confident the macOS wheels here will be fine going forward.

@aiudirog
Copy link
Member

This looks great! Can we do an RC release (either 1.8.0rc1 or 1.7.1rc1, not sure where we are semver speaking) so the wheels get built this way and uploaded to PyPI but not set as the default for the public yet? Then I can run some tests on them exactly as they will be built.

@jborean93
Copy link
ContributorAuthor

That's a good idea, I'll probably settle on1.7.1rc1 as functionality there are no changes to the library, just the new wheel. There shouldn't be any breaking changes and hopefully the rc will prove that.

@jborean93jborean93 merged commit7c0c20a intopythongssapi:mainOct 6, 2021
@jborean93jborean93 deleted the macOS-wheel branchOctober 6, 2021 18:58
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MacOS wheels

2 participants

@jborean93@aiudirog

[8]ページ先頭

©2009-2025 Movatter.jp