- Notifications
You must be signed in to change notification settings - Fork52
Use distutils provided by setuptools#265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The distutils module provided by the stdlib has been deprecated inPython 3.10. This PR sets an env var that is read by setuptools whichwill shim its vendored copy of distutils if present avoiding a failureonce distutils is removed from the stdlib.Signed-off-by: Jordan Borean <jborean93@gmail.com>
aiudirog approved these changesOct 5, 2021
Member
aiudirog left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good to me!
ContributorAuthor
jborean93 commentedOct 5, 2021
Thanks for testing it out@aiudirog |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The distutils module provided by the stdlib has been deprecated in
Python 3.10. This PR sets an env var that is read by setuptools which
will shim its vendored copy of distutils if present avoiding a failure
once distutils is removed from the stdlib.
Signed-off-by: Jordan Boreanjborean93@gmail.com
Fixes#259