- Notifications
You must be signed in to change notification settings - Fork52
Fix GSSAPI detection on macOS Big Sur#236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
simmel commentedDec 10, 2020
Also builds for me. Great work! |
CPython on macOS Big Sur has a bug in the ctypes.util.find_libraryfunction. This has been fixed recently but has not made its way to anactual release yet. This change adds a fallback GSS framework path totry incase ctypes fails to find the path.[rharwood@redhat.com: whitespace, wrapping]
frozencemetery approved these changesDec 10, 2020
Member
frozencemetery commentedDec 10, 2020
While GitHub Actions lists a label for Big Sur, it doesn't actually run on Big Sur right now, so CI isn't yet possible for this platform. |
Closed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CPython on macOS Big Sur has a bug in the ctypes.util.find_library function.
This has been fixed recently but has not made its way to an actual release
yet. This change adds a fallback GSS framework path to try incase ctypes fails
to find the path.
Fixes#235