- Notifications
You must be signed in to change notification settings - Fork343
Fix math point types#2430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fix math point types#2430
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
TL;DR: I'm undecided on thePoint2 change, but I have suggestions on the doc and the doc
@DragonMoffon any thoughts on consistency forPoint2 vs the perf dangers ofVec2?
@Rapen765 The CI's linter complaints. Could you please try the following in your local repo clone?
- Make sure your venv's activated
./make.py format && ./make.py ruff- Commit & push
I def think Point2 should be used over tuple[float, float] everywhere. The only place it shouldn't be used is anything that returns a |
Co-authored-by: Paul <36696816+pushfoo@users.noreply.github.com>
Co-authored-by: Paul <36696816+pushfoo@users.noreply.github.com>
Ty for the contribution and sorry for the wait! |
Changed functions' return type from
tuple[float, float]toPoint2.Fixed documentation of
rand_vec_magnitudeandrand_on_circle.