Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix math point types#2430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

Rapen765
Copy link
Contributor

Changed functions' return type fromtuple[float, float] toPoint2.
Fixed documentation ofrand_vec_magnitude andrand_on_circle.

Copy link
Member

@pushfoopushfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

TL;DR: I'm undecided on thePoint2 change, but I have suggestions on the doc and the doc

@DragonMoffon any thoughts on consistency forPoint2 vs the perf dangers ofVec2?

@Rapen765 The CI's linter complaints. Could you please try the following in your local repo clone?

  1. Make sure your venv's activated
  2. ./make.py format && ./make.py ruff
  3. Commit & push

@DragonMoffon
Copy link
Collaborator

I def think Point2 should be used over tuple[float, float] everywhere. The only place it shouldn't be used is anything that returns atuple[int, int] that should have a different alias (Size2 maybe)

Rapen765and others added3 commitsOctober 22, 2024 16:05
Co-authored-by: Paul <36696816+pushfoo@users.noreply.github.com>
Co-authored-by: Paul <36696816+pushfoo@users.noreply.github.com>
@pushfoopushfoo merged commitc01c2ce intopythonarcade:developmentJan 1, 2025
8 checks passed
@pushfoo
Copy link
Member

Ty for the contribution and sorry for the wait!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@pushfoopushfoopushfoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Rapen765@DragonMoffon@pushfoo
[8]ページ先頭
©2009-2025 Movatter.jp