Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Issue 2077: Add sample playwright tests for folium#2127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
hansthen wants to merge31 commits intopython-visualization:main
base:main
Choose a base branch
Loading
fromhansthen:playwright_tests

Conversation

hansthen
Copy link
Collaborator

@hansthenhansthen commentedApr 7, 2025
edited
Loading

Gentlemen, I created a sample test using playwright and streamlit. This is not a full test suite, but more of a demonstration how we can use Playwright to test our example apps. I have used Playwright for a few other projects and I like how it works. It also comes with a nicecodegen utility that can be used to jumpstart creating tests.

Let me know what you think of it.

@hansthenhansthen marked this pull request as draftApril 7, 2025 18:08
@hansthenhansthenforce-pushed theplaywright_tests branch 2 times, most recently fromce6081a toe531057CompareApril 14, 2025 18:20
@hansthenhansthen changed the titleAdd sample playwright tests for foliumIssue 2077: Add sample playwright tests for foliumApr 19, 2025
@hansthenhansthen marked this pull request as ready for reviewApril 19, 2025 05:23
@hansthen
Copy link
CollaboratorAuthor

I am okay with the results for now. Please let me know what you think.

@ocefpaf
Copy link
Member

ocefpaf commentedApr 22, 2025
edited
Loading

I am okay with the results for now. Please let me know what you think.

I don't know whatplaywright is, and I'm not familiar enough withstreamlit to review this PR. I'll leave this one for you and Frank. Sorry.

@hansthen
Copy link
CollaboratorAuthor

I am okay with the results for now. Please let me know what you think.

I don't know whatplaywright is, and I'm not familiar enough withstreamlit to review this PR. I'll leave this one for you and Frank. Sorry.

No problem. Playwright is a UI testing framework that is also used by the streamlit-folium people. It feels a lot like selenium, but with less baggage. I will make this PR a draft for now and focus first on getting the regressions to work.

ocefpaf reacted with thumbs up emoji

@hansthenhansthen marked this pull request as draftApril 22, 2025 16:18
@ocefpaf
Copy link
Member

It feels a lot like selenium, but with less baggage.

Cool! I'll watch this closely to learn something new.

@hansthen
Copy link
CollaboratorAuthor

It feels a lot like selenium, but with less baggage.

Cool! I'll watch this closely to learn something new.

Thank you for your help! Half a dozen issues closed in a single day. I will prepare a release soon.

ocefpaf reacted with rocket emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ocefpafocefpafAwaiting requested review from ocefpaf

@ConengmoConengmoAwaiting requested review from Conengmo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@hansthen@ocefpaf

[8]ページ先頭

©2009-2025 Movatter.jp