- Notifications
You must be signed in to change notification settings - Fork5.9k
fix event loop is closed#5030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hey, thanks for the PR!
I've left some comments. In addition to that, we'll need new unit tests that cover the changes. If you need some pointers on where to get started, please let me know.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for the updates. I've left some new comments below. Please let me know in case you have any questions on them. In addition
- please have a look at the test coverage reporthttps://app.codecov.io/gh/python-telegram-bot/python-telegram-bot/pull/5030. It should also show in the CI checks on github usually. Don't know why it doesn't so far …
- please add a file
changes/unreleased/5030.bBRC3598kUYHL2Qpo4gjMb.tomlwith the content
bugfixes ="Fix a Bug in Initialization Logic of ``Bot``"[[pull_requests]]uid ="5030"author_uids = ["codomposer"]closes_threads = ["5021"]
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
@Bibo-Joshi |
@codomposer Hey. I will come back to this, when I have the time and mental capacity for it, yes. |
Uh oh!
There was an error while loading.Please reload this page.
Fixes
Closes#5021
Check-list for PRs
.. versionadded:: NEXT.VERSION,.. versionchanged:: NEXT.VERSION,.. deprecated:: NEXT.VERSIONor ``.. versionremoved:: NEXT.VERSION` to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)AUTHORS.rst(optional)__all__sIf the PR contains API changes (otherwise, you can ignore this passage) - N/A
New Classes
self._id_attrsand corresponding documentationapi_kwargsas keyword-onlyAdded New Shortcuts
telegram.Chat&telegram.Userfor all methods that acceptchat/user_idtelegram.Messagefor all methods that acceptchat_idandmessage_idtelegram.Messageshortcuts: Addedquoteargument if methods acceptreply_to_message_idtelegram.CallbackQueryfor all methods that accept eitherchat_idandmessage_idorinline_message_idIf Relevant
telegram.constantsand shortcuts to them as class variablestelegram.Message.effective_attachmenttelegram.ext.ConversationHandler_extbot.pybot_methods.rstREADME.rst(including the badge) andtelegram.constants.BOT_API_VERSION_INFOtelegram.ext.ExtBotfor new methods that either accept areply_markupin some form or have a return type that is/containstelegram.MessageContribution by Gittensor, learn more athttps://gittensor.io/