Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix event loop is closed#5030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
codomposer wants to merge6 commits intopython-telegram-bot:master
base:master
Choose a base branch
Loading
fromcodomposer:fix/event_loop

Conversation

@codomposer
Copy link

@codomposercodomposer commentedOct 30, 2025
edited
Loading

Fixes

Closes#5021

Check-list for PRs

  • Added.. versionadded:: NEXT.VERSION,.. versionchanged:: NEXT.VERSION,.. deprecated:: NEXT.VERSION or ``.. versionremoved:: NEXT.VERSION` to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to theCSI standard
  • Added myself alphabetically toAUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable__all__ s
  • Checked theStability Policy in case of deprecations or changes to documented behavior

If the PR contains API changes (otherwise, you can ignore this passage) - N/A

  • New Classes

    • Addedself._id_attrs and corresponding documentation
    • init acceptsapi_kwargs as keyword-only
  • Added New Shortcuts

    • Intelegram.Chat &telegram.User for all methods that acceptchat/user_id
    • Intelegram.Message for all methods that acceptchat_id andmessage_id
    • For newtelegram.Message shortcuts: Addedquote argument if methods acceptreply_to_message_id
    • Intelegram.CallbackQuery for all methods that accept eitherchat_id andmessage_id orinline_message_id
  • If Relevant

    • Added new constants attelegram.constants and shortcuts to them as class variables
    • Linked new and existing constants in docstrings instead of hard-coded numbers and strings
    • Added new message types totelegram.Message.effective_attachment
    • Added new handlers for new update types
    • Added new filters for new message (sub)types
    • Added or updated documentation for the changed class(es) and/or method(s)
    • Added the new method(s) to_extbot.py
    • Added or updatedbot_methods.rst
    • Updated the Bot API version number in all places:README.rst (including the badge) andtelegram.constants.BOT_API_VERSION_INFO
    • Added logic for arbitrary callback data intelegram.ext.ExtBot for new methods that either accept areply_markup in some form or have a return type that is/containstelegram.Message

Contribution by Gittensor, learn more athttps://gittensor.io/

Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hey, thanks for the PR!
I've left some comments. In addition to that, we'll need new unit tests that cover the changes. If you need some pointers on where to get started, please let me know.

Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the updates. I've left some new comments below. Please let me know in case you have any questions on them. In addition

bugfixes ="Fix a Bug in Initialization Logic of ``Bot``"[[pull_requests]]uid ="5030"author_uids = ["codomposer"]closes_threads = ["5021"]

@codomposer
Copy link
Author

@Bibo-Joshi
can you please check this PR again?

@Bibo-Joshi
Copy link
Member

@codomposer Hey. I will come back to this, when I have the time and mental capacity for it, yes.

codomposer reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@Bibo-JoshiBibo-JoshiAwaiting requested review from Bibo-Joshi

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RuntimeError: Event loop is closed

2 participants

@codomposer@Bibo-Joshi

[8]ページ先頭

©2009-2025 Movatter.jp