Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Rework Repository tosrc Layout#4798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Bibo-Joshi wants to merge6 commits intomaster
base:master
Choose a base branch
Loading
fromsrc-layout
Open

Rework Repository tosrc Layout#4798

Bibo-Joshi wants to merge6 commits intomasterfromsrc-layout

Conversation

Bibo-Joshi
Copy link
Member

@Bibo-JoshiBibo-Joshi commentedMay 22, 2025•
edited
Loading

When readycloses#4797

Needs manual verification that

  • wheels are build correctly
  • mypy & code coverage are working as expected

I totally just let GH Copilot Agent run for 10 minutes and just manually fixed a few obvious things in the diff 😅

@Bibo-JoshiBibo-Joshi added the 🛠 code-qualitychange type: code-quality labelMay 22, 2025
@github-actionsgithub-actionsbot removed the 🛠 code-qualitychange type: code-quality labelMay 22, 2025
@Bibo-JoshiBibo-Joshi changed the titleChange tosrc LayoutRework Repository tosrc LayoutMay 23, 2025
@Bibo-Joshi
Copy link
MemberAuthor

Bibo-Joshi commentedMay 23, 2025•
edited
Loading

About6c7cf83: I've done this now like I did forchango. I'm not sure though if that's the best way. Note that the source distribution now includes many more files than before. If anyone has suggsetions on best practices, I'm happy for input.

Installing from these distributions works, though, I've tested that

@Bibo-JoshiBibo-Joshi marked this pull request as ready for reviewMay 23, 2025 21:48
@Bibo-JoshiBibo-Joshi requested review fromCopilot,harshil21 andPoolitzer and removed request forharshil21May 23, 2025 21:48
Copy link

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR reworks the repository layout to use a src-based structure, moving package code from telegram to src/telegram.

  • Update configuration in pyproject.toml for versioning, builds, linting, testing, and type checking.
  • Adjust CI workflows to use the new src/telegram path.
  • Update contribution documentation to reflect the new layout.

Reviewed Changes

Copilot reviewed 232 out of 232 changed files in this pull request and generated 1 comment.

Show a summary per file
FileDescription
pyproject.tomlUpdated package paths and build configurations
changes/unreleased/4798.g7G3jRf2ns4ath9LRFEcit.tomlAdded changelog entry for the repository rework
.github/workflows/unit_tests.ymlUpdated test path to src/telegram
.github/workflows/type_completeness.ymlUpdated test path to src/telegram
.github/workflows/test_official.ymlUpdated test path to src/telegram
.github/workflows/docs-admonitions.ymlUpdated test path to src/telegram
.github/CONTRIBUTING.rstExtended instructions to reflect the new src layout

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@PoolitzerPoolitzerAwaiting requested review from Poolitzer

@harshil21harshil21Awaiting requested review from harshil21

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use a src layout instead of a flat layout
1 participant
@Bibo-Joshi
[8]ページ先頭
©2009-2025 Movatter.jp