Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Api 9.0 premium#4781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Bibo-Joshi merged 9 commits intoapi_9.0fromapi_9.0-premium
May 12, 2025
Merged

Api 9.0 premium#4781

Bibo-Joshi merged 9 commits intoapi_9.0fromapi_9.0-premium
May 12, 2025

Conversation

aelkheir
Copy link
Member

@aelkheiraelkheir commentedMay 4, 2025
edited
Loading

Check-list for PRs

  • Added.. versionadded:: NEXT.VERSION,.. versionchanged:: NEXT.VERSION,.. deprecated:: NEXT.VERSION or.. versionremoved:: NEXT.VERSION to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to theCSI standard <https://standards.mousepawmedia.com/en/stable/csi.html>__
  • Added new classes & modules to the docs and all suitable__all__ s
  • Checked theStability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_ in case of deprecations or changes to documented behavior

If the PR contains API changes (otherwise, you can ignore this passage)

  • Checked the Bot API specific sections of theStability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_

  • Created a PR to remove functionality deprecated in the previous Bot API release (see here <https://docs.python-telegram-bot.org/en/stable/stability_policy.html#case-2>_)

  • New classes:

    • Addedself._id_attrs and corresponding documentation
  • Added new shortcuts:

    • In :class:~telegram.Chat & :class:~telegram.User for all methods that acceptchat/user_id
    • In :class:~telegram.Message for all methods that acceptchat_id andmessage_id
    • For new :class:~telegram.Message shortcuts: Addedquote argument if methods acceptsreply_to_message_id
    • In :class:~telegram.CallbackQuery for all methods that accept eitherchat_id andmessage_id orinline_message_id
  • If relevant:

    • Added new constants at :mod:telegram.constants and shortcuts to them as class variables
    • Link new and existing constants in docstrings instead of hard-coded numbers and strings
    • Added or updated documentation for the changed class(es) and/or method(s)
    • Added the new method(s) to_extbot.py
    • Added or updatedbot_methods.rst

Telegram Premium

  • Added the method giftPremiumSubscription, allowing bots to gift a user a Telegram Premium subscription paid in Telegram Stars.
  • Added the field premium_subscription_duration to the class TransactionPartnerUser for transactions involving a Telegram Premium subscription purchased by the bot.
  • Added the field transaction_type to the class TransactionPartnerUser, simplifying the differentiation and processing of all transaction types.

Telegram Premium- Added the method giftPremiumSubscription, allowing bots to gift a user  a Telegram Premium subscription paid in Telegram Stars.
Telegram Premium- Added the field premium_subscription_duration to the class  TransactionPartnerUser for transactions involving a Telegram Premium  subscription purchased by the bot.- Added the field transaction_type to the class TransactionPartnerUser,  simplifying the differentiation and processing of all transaction types.
@aelkheiraelkheir mentioned this pull requestMay 4, 2025
35 tasks
@Bibo-JoshiBibo-Joshi requested a review fromCopilotMay 4, 2025 19:19
Copy link

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR introduces Telegram Premium subscription gifting functionality and related API changes. Key updates include adding the new method gift_premium_subscription in both the extbot and bot modules, updating the TransactionPartnerUser class to require a new transaction_type (and premium_subscription_duration), and adding the PremiumSubscription enum with associated constants.

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
FileDescription
tests/test_official/exceptions.pyExtended the ignored parameters mapping to include TransactionPartnerUser.transaction_type.
tests/test_bot.pyAdded tests for gift_premium_subscription with validations for proper parameter mapping.
tests/_payment/stars/test_transactionpartner.pyUpdated tests and fixtures for TransactionPartnerUser to incorporate transaction_type and premium_subscription_duration.
tests/_payment/stars/test_startransactions.pyAdjusted TransactionPartnerUser instantiations; one instance uses a nonstandard transaction_type.
telegram/ext/_extbot.pyAdded gift_premium_subscription method and its alias giftPremiumSubscription.
telegram/constants.pyIntroduced the PremiumSubscription enum and updated the constants list.
telegram/_payment/stars/transactionpartner.pyUpdated TransactionPartnerUser to enforce and include transaction_type and premium_subscription_duration in equality comparisons.
telegram/_bot.pyAdded gift_premium_subscription with thorough docstrings and created camelCase aliases.
changes/unreleased/4756.JT5nmUmGRG6qDEh5ScMn5f.tomlUpdated changelog to reference a new pull request closing threads.
Files not reviewed (1)
  • docs/source/inclusions/bot_methods.rst: Language not supported

Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hey, thanks for another api 9.0 PR :D You didn't request a review yet, I hope it's okay that I went ahead already anways. I saw only a few minor things in the code. What I did notice is that a shortcutUser.gift_premium_subscription would make sense :)

- Add shortcut User.gift_premium_subscription- Add a missing ".. versionadded"- Update "deprecations" change note to recommend using keyword  arguments for added required fields to existing classes.
@aelkheir
Copy link
MemberAuthor

Perfectly fine, I just forgot to request the review :D
Replied back with a few comments.

# Conflicts:#changes/unreleased/4756.JT5nmUmGRG6qDEh5ScMn5f.toml
@Bibo-JoshiBibo-Joshi merged commitc1e6b5b intoapi_9.0May 12, 2025
24 of 25 checks passed
@Bibo-JoshiBibo-Joshi deleted the api_9.0-premium branchMay 12, 2025 19:06
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 20, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@Bibo-JoshiBibo-JoshiBibo-Joshi left review comments

Copilot code reviewCopilotCopilot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@aelkheir@Bibo-Joshi

[8]ページ先頭

©2009-2025 Movatter.jp