Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Api 9.0 business stories#4769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Bibo-Joshi merged 8 commits intoapi_9.0fromapi_9.0-business-stories
Apr 28, 2025
Merged

Conversation

aelkheir
Copy link
Member

Check-list for PRs

  • Added.. versionadded:: NEXT.VERSION,.. versionchanged:: NEXT.VERSION,.. deprecated:: NEXT.VERSION or.. versionremoved:: NEXT.VERSION to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to theCSI standard <https://standards.mousepawmedia.com/en/stable/csi.html>__
  • Added new classes & modules to the docs and all suitable__all__ s
  • Checked theStability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_ in case of deprecations or changes to documented behavior

If the PR contains API changes (otherwise, you can ignore this passage)

  • Checked the Bot API specific sections of theStability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_

  • Created a PR to remove functionality deprecated in the previous Bot API release (see here <https://docs.python-telegram-bot.org/en/stable/stability_policy.html#case-2>_)

  • New classes:

    • Addedself._id_attrs and corresponding documentation
  • Added new shortcuts:

    • In :class:~telegram.Chat & :class:~telegram.User for all methods that acceptchat/user_id
    • In :class:~telegram.Message for all methods that acceptchat_id andmessage_id
    • For new :class:~telegram.Message shortcuts: Addedquote argument if methods acceptsreply_to_message_id
    • In :class:~telegram.CallbackQuery for all methods that accept eitherchat_id andmessage_id orinline_message_id
  • If relevant:

    • Added new constants at :mod:telegram.constants and shortcuts to them as class variables
    • Link new and existing constants in docstrings instead of hard-coded numbers and strings
    • Add new message types to :attr:telegram.Message.effective_attachment
    • Added new handlers for new update types
    • Added or updated documentation for the changed class(es) and/or method(s)
    • Added the new method(s) to_extbot.py
    • Added or updatedbot_methods.rst

Business Accounts

Business Accounts- Added the classes `InputStoryContentPhoto` and `InputStoryContentVideo`  representing the content of a story to post.
Business Accounts- Added the classes `StoryArea`, `StoryAreaPosition`, `LocationAddress`,  `StoryAreaTypeLocation`, `StoryAreaTypeSuggestedReaction`,  `StoryAreaTypeLink`, `StoryAreaTypeWeather` and  `StoryAreaTypeUniqueGift`, describing clickable active areas on stories.
Business Accounts- Added the method `postStory`, allowing bots to post a story on behalf of  a managed business account.- Added the method `editStory`, allowing bots to edit stories they had  previously posted on behalf of a managed business account.- Added the method `deleteStory`, allowing bots to delete stories they had  previously posted on behalf of a managed business account.
@aelkheiraelkheir mentioned this pull requestApr 26, 2025
35 tasks
1. a missing `self._freez()`2. a missing exception to `test_types_are_converted_to_enum`.
@aelkheiraelkheir added the 📋 pending-reviewwork status: pending-review labelApr 26, 2025
Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Very nice, almost nothing to comment! You included all test cases for default handling, local files etc as well, awesome 💪

Copy link

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR introduces new functionality to support story-related features for business accounts in the API. Key changes include:

  • Addition of new story endpoints (post_story, edit_story, delete_story) in both the ext bot and core bot modules.
  • Introduction of new classes for handling story content (InputStoryContent, InputStoryContentPhoto, InputStoryContentVideo) in a separate file.
  • Extension of constants with new story-related limits and types.

Reviewed Changes

Copilot reviewed 15 out of 29 changed files in this pull request and generated 1 comment.

Show a summary per file
FileDescription
telegram/ext/_extbot.pyAdded post_story, edit_story, delete_story methods and aliases.
telegram/constants.pyAdded enums for InputStoryContentLimit, StoryArea limits, etc.
telegram/_files/_inputstorycontent.pyAdded new classes for story content handling.
telegram/_bot.pyIntroduced story API methods with corresponding docstrings.
telegram/init.pyExported new story-related classes and constants.
changes/unreleased/4756.JT5nmUmGRG6qDEh5ScMn5f.tomlUpdated pull request metadata linking to this change.
Files not reviewed (14)
  • docs/source/inclusions/bot_methods.rst: Language not supported
  • docs/source/telegram.at-tree.rst: Language not supported
  • docs/source/telegram.inputstorycontent.rst: Language not supported
  • docs/source/telegram.inputstorycontentphoto.rst: Language not supported
  • docs/source/telegram.inputstorycontentvideo.rst: Language not supported
  • docs/source/telegram.locationaddress.rst: Language not supported
  • docs/source/telegram.storyarea.rst: Language not supported
  • docs/source/telegram.storyareaposition.rst: Language not supported
  • docs/source/telegram.storyareatype.rst: Language not supported
  • docs/source/telegram.storyareatypelink.rst: Language not supported
  • docs/source/telegram.storyareatypelocation.rst: Language not supported
  • docs/source/telegram.storyareatypesuggestedreaction.rst: Language not supported
  • docs/source/telegram.storyareatypeuniquegift.rst: Language not supported
  • docs/source/telegram.storyareatypeweather.rst: Language not supported
Comments suppressed due to low confidence (2)

telegram/_bot.py:9780

  • The delete_story method is calling the 'deleteBusinessMessages' endpoint instead of the correct 'deleteStory' endpoint. Please update the endpoint to match the new story API.
return await self._post("deleteBusinessMessages", data,

telegram/constants.py:2826

  • [nitpick] The name 'StoryAreaTypeType' is a bit redundant and may be confusing. Consider renaming it to 'StoryAreaTypeEnum' for clarity.
class StoryAreaTypeType(StringEnum):

Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

copilot did find something :)

…-storiesConflicts:changes/unreleased/4756.JT5nmUmGRG6qDEh5ScMn5f.tomldocs/source/inclusions/bot_methods.rsttelegram/constants.pytelegram/request/_requestparameter.pytests/request/test_requestparameter.pytests/test_business_methods.pytests/test_official/exceptions.py
@Bibo-JoshiBibo-Joshi merged commit6e202f3 intoapi_9.0Apr 28, 2025
25 of 26 checks passed
@Bibo-JoshiBibo-Joshi deleted the api_9.0-business-stories branchApril 28, 2025 20:17
@aelkheiraelkheir removed the 📋 pending-reviewwork status: pending-review labelApr 28, 2025
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 6, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

Copilot code reviewCopilotCopilot left review comments

@Bibo-JoshiBibo-JoshiBibo-Joshi approved these changes

@vipzonevipvipzonevipvipzonevip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@aelkheir@Bibo-Joshi@vipzonevip

[8]ページ先頭

©2009-2025 Movatter.jp