python-telegram-bot/python-telegram-botPublic

NotificationsYou must be signed in to change notification settings
Fork5.7k
Star27.6k

Api 9.0 profile photos#4766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Bibo-Joshi merged 16 commits intoapi_9.0fromapi_9.0-profile-photos

Apr 28, 2025

Merged

Api 9.0 profile photos#4766

Bibo-Joshi merged 16 commits intoapi_9.0fromapi_9.0-profile-photos

Apr 28, 2025

Conversation

Copy link

Member

Bibo-Joshi commentedApr 24, 2025

Check-list for PRs

Added.. versionadded:: NEXT.VERSION,.. versionchanged:: NEXT.VERSION,.. deprecated:: NEXT.VERSION or.. versionremoved:: NEXT.VERSION to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
Created new or adapted existing unit tests
Documented code changes according to theCSI standard <https://standards.mousepawmedia.com/en/stable/csi.html>__
Added new classes & modules to the docs and all suitable__all__ s
Checked theStability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_ in case of deprecations or changes to documented behavior

If the PR contains API changes (otherwise, you can ignore this passage)

Checked the Bot API specific sections of theStability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_
Created a PR to remove functionality deprecated in the previous Bot API release (see here <https://docs.python-telegram-bot.org/en/stable/stability_policy.html#case-2>_)
New classes:
- ~~Addedself._id_attrs and corresponding documentation~~
Added new shortcuts:
- ~~In :class:~telegram.Chat & :class:~telegram.User for all methods that acceptchat/user_id~~
If relevant:
- Added new constants at :mod:telegram.constants and shortcuts to them as class variables
- Link new and existing constants in docstrings instead of hard-coded numbers and strings
- ~~Added new filters for new message (sub)types~~
- Added the new method(s) to_extbot.py
- Added or updatedbot_methods.rst

Bibo-Joshi added4 commits

April 24, 2025 20:35

InputProfilePhoto* classes

1fcfb5a

set_remove_b_a_profile_photo

134a3b6

doc update

471cd9f

update chango fragment

6ea9392

Bibo-Joshi added the ⚙️ bot-apiaffected functionality: bot-api label

Apr 24, 2025

Bibo-Joshi requested a review fromCopilot

April 24, 2025 19:28

Add chango fragment for PR#4766

db88e52

CopilotAI reviewed

Apr 24, 2025

View reviewed changes

Copy link

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR implements API 9.0 support for business account profile photos by adding new input types, constants, and corresponding bot methods as well as associated tests. Key changes include:

New InputProfilePhoto classes (static and animated) and corresponding type enums.
Addition of new bot methods and aliases in _bot.py and _extbot.py.
New and updated tests to cover profile photo functionality.

Reviewed Changes

Copilot reviewed 10 out of 15 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tests/test_business_methods.py	Added tests for setting and removing business account profile photos.
tests/request/test_requestparameter.py	Added tests for profile photo input conversion in request parameters.
tests/_files/test_inputprofilephoto.py	Added tests for InputProfilePhoto behavior.
telegram/request/_requestparameter.py	Updated input handling to support InputProfilePhoto instances.
telegram/ext/_extbot.py	Added business account profile photo methods and their aliases.
telegram/constants.py	Introduced InputProfilePhotoType enum.
telegram/_files/inputprofilephoto.py	New file for InputProfilePhoto, InputProfilePhotoStatic, and InputProfilePhotoAnimated.
telegram/_bot.py	Added bot methods for profile photo operations and updated docstrings.
telegram/init.py	Updated public API exports.
changes/unreleased/4756.JT5nmUmGRG6qDEh5ScMn5f.toml	Recorded the new changes in the changelog.

Files not reviewed (5)

docs/source/inclusions/bot_methods.rst: Language not supported
docs/source/telegram.at-tree.rst: Language not supported
docs/source/telegram.inputprofilephoto.rst: Language not supported
docs/source/telegram.inputprofilephotoanimated.rst: Language not supported
docs/source/telegram.inputprofilephotostatic.rst: Language not supported

telegram/_files/inputprofilephoto.py OutdatedShow resolvedHide resolved

telegram/_bot.py OutdatedShow resolvedHide resolved

Bibo-Joshiand others added4 commits

April 24, 2025 21:29

update chango fragment

129e7ee

typos - thanks copilot

717cf1a

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

test_official

ca75aa7

fix ext bot signature

cecba9c

Bibo-Joshi mentioned this pull request

Apr 24, 2025

Full Support for Bot API 9.0#4754

Closed

35 tasks

Bibo-Joshi marked this pull request as ready for review

April 24, 2025 19:56

Bibo-Joshi requested review fromharshil21 andaelkheir

April 24, 2025 19:56

aelkheir reviewed

Apr 24, 2025

View reviewed changes

Copy link

Member

aelkheir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

looking good.. didn't review everything but these places caught my eye..

telegram/_files/inputprofilephoto.pyShow resolvedHide resolved

telegram/_files/inputprofilephoto.py OutdatedShow resolvedHide resolved

telegram/_files/inputprofilephoto.pyShow resolvedHide resolved

tests/test_business_methods.pyShow resolvedHide resolved

Bibo-Joshiand others added2 commits

April 25, 2025 16:23

Update telegram/_files/inputprofilephoto.py

08717b0

Co-authored-by: Abdelrahman Elkheir <90580077+aelkheir@users.noreply.github.com>

Update telegram/_files/inputprofilephoto.py

c5a817b

Co-authored-by: Abdelrahman Elkheir <90580077+aelkheir@users.noreply.github.com>

harshil21 requested changes

Apr 25, 2025

View reviewed changes

Copy link

Member

harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

just a few minor kinks

docs/source/inclusions/bot_methods.rst OutdatedShow resolvedHide resolved

telegram/_files/inputprofilephoto.py OutdatedShow resolvedHide resolved

telegram/_files/inputprofilephoto.pyShow resolvedHide resolved

telegram/request/_requestparameter.pyShow resolvedHide resolved

tests/test_official/exceptions.pyShow resolvedHide resolved

Bibo-Joshi added5 commits

April 27, 2025 18:26

reviews :)

a7e289c

Add chango fragment for PR#4766

dd1bbeb

Delete changes/unreleased/4766.JT5nmUmGRG6qDEh5ScMn5f.toml

e87abe7

Add chango fragment for PR#4766

f8f88c4

Delete changes/unreleased/4766.JT5nmUmGRG6qDEh5ScMn5f.toml

6383fe9

Bibo-Joshi requested review fromaelkheir andharshil21

April 27, 2025 17:03

harshil21 approved these changes

Apr 27, 2025

View reviewed changes

Copy link

Member

harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

aelkheir approved these changes

Apr 27, 2025

View reviewed changes

Copy link

Member

aelkheir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good to go!

Bibo-Joshi merged commit380282e intoapi_9.0

Apr 28, 2025

24 of 26 checks passed

Bibo-Joshi deleted the api_9.0-profile-photos branch

April 28, 2025 16:29

github-actionsbot locked and limited conversation to collaborators

May 6, 2025

Labels

⚙️ bot-api

affected functionality: bot-api

3 participants

Movatterモバイル変換

Api 9.0 profile photos#4766

Api 9.0 profile photos#4766

Uh oh!

Conversation

Bibo-Joshi commentedApr 24, 2025

Check-list for PRs

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aelkheir left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

harshil21 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

harshil21 left a comment

Choose a reason for hiding this comment

Uh oh!

aelkheir left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!