- Notifications
You must be signed in to change notification settings - Fork5.7k
Api 9.0 business methods#4757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hey! Changes look good 😄 , just left some minor comments.
Uh oh!
There was an error while loading.Please reload this page.
| user = User(1, "first", False) | ||
| user_chat_id = 1 | ||
| date = dtm.datetime.utcnow() | ||
| can_reply = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
just a reminder this will also need to be adjusted if/when
- Added the classBusinessBotRights and replaced the field can_reply with the field rights of the typeBusinessBotRights in the classBusinessConnection.
gets merged first.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
the set_business_account_profile_photo and remove_business_account_profile_photo methods are missing, not sure if that was intentional or not...
I'm fine with the naming of message.read_business_message. Rest of the changes look good to me!
Yup, those require new classes which I didn't have time to implement yet :)
🥳 |
Co-authored-by: Abdelrahman Elkheir <90580077+aelkheir@users.noreply.github.com>
2144c78 intoapi_9.0Uh oh!
There was an error while loading.Please reload this page.
Message.read_business_messagecan be discussed. JustMessage.readdoesn't sufficiently highlight the business connection IMO butMessage.read_business_messageis the complete name again … not really happy with it.