- Notifications
You must be signed in to change notification settings - Fork5.7k
Addname
andfull_name
properties to theSharedUser
class#4708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Addname
andfull_name
properties to theSharedUser
class#4708
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…as in the `telegram.User` class.
Hi. Thanks for the PR, nice idea 👍
and your PR basically copies classUserLike(typing.Protocol):first_name:typing.Optional[str]last_name:typing.Optional[str]username:typing.Optional[str] Would that be doable for you? Note that you can copy the tests from |
Closing in favor of#4713 |
P.S. I failed to update the documentation. Sphinx requires Python 3.12, but I intentionally use Python 3.10. The documentation states that Python 3.9+ is supported, as mentioned in the introduction section:python-telegram-bot Introduction.
Please review the PR, and if everything is okay, I will try to write the documentation.