Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Full Support for Bot API 8.2#4633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Bibo-Joshi merged 11 commits intomasterfromapi_8.2
Jan 3, 2025
Merged

Full Support for Bot API 8.2#4633

Bibo-Joshi merged 11 commits intomasterfromapi_8.2
Jan 3, 2025

Conversation

Poolitzer
Copy link
Member

@PoolitzerPoolitzer commentedJan 1, 2025
edited by Bibo-Joshi
Loading

I am surprised no test failed when I deprecated the hide_url argument, but I am too tired rn to decide if that is good/bad or if I already fixed it.

@codecovCodecov
Copy link

codecovbot commentedJan 1, 2025
edited
Loading

❌ 2 Tests Failed:

Tests completedFailedPassedSkipped
657326571481
View the top 2 failed tests by shortest run time
tests.test_bot.TestBotWithRequest::test_get_set_my_default_administrator_rights
Stack Traces | 0.786s run time
self=<tests.test_bot.TestBotWithRequestobjectat0x0000028C39852230>bot=PytestExtBot[token=695104088:AAHfzylIOjSIIS-eOnI20y2E20HodHsfz-0]asyncdeftest_get_set_my_default_administrator_rights(self,bot):# Test that my default administrator rights for group are as all Falseassertawaitbot.set_my_default_administrator_rights()# clear any set rightsmy_admin_rights_grp=awaitbot.get_my_default_administrator_rights()assertisinstance(my_admin_rights_grp,ChatAdministratorRights)assertall(notgetattr(my_admin_rights_grp,at)foratinmy_admin_rights_grp.__slots__)# Test setting my default admin rights for channelmy_rights=ChatAdministratorRights.all_rights()assertawaitbot.set_my_default_administrator_rights(my_rights,for_channels=True)my_admin_rights_ch=awaitbot.get_my_default_administrator_rights(for_channels=True)>assertmy_admin_rights_ch.can_invite_usersismy_rights.can_invite_usersEassertFalseisTrueE+whereFalse=ChatAdministratorRights(can_change_info=False,can_delete_messages=False,can_delete_stories=False,can_edit_messages=False,can_edit_stories=False,can_invite_users=False,can_manage_chat=False,can_manage_video_chats=False,can_post_messages=False,can_post_stories=False,can_promote_members=False,can_restrict_members=False,is_anonymous=False).can_invite_usersE+andTrue=ChatAdministratorRights(can_change_info=True,can_delete_messages=True,can_delete_stories=True,can_edit_messages=True,can_edit_stories=True,can_invite_users=True,can_manage_chat=True,can_manage_topics=True,can_manage_video_chats=True,can_pin_messages=True,can_post_messages=True,can_post_stories=True,can_promote_members=True,can_restrict_members=True,is_anonymous=True).can_invite_userstests\test_bot.py:3900:AssertionError
tests.test_bot.TestBotWithRequest::test_send_close_date_default_tz[UTC-timezone]
Stack Traces | 5.21s run time
self=<tests.test_bot.TestBotWithRequestobjectat0x000001B2D7987350>tz_bot=PytestExtBot[token=1047326771:AAF8nOt81FpX8lbbvz8UewQQvRfTbFfBvuI]super_group_id='-1001484797612'asyncdeftest_send_close_date_default_tz(self,tz_bot,super_group_id):question="Is this a test?"answers= ["Yes","No","Maybe"]reply_markup=InlineKeyboardMarkup.from_button(InlineKeyboardButton(text="text",callback_data="data")        )aware_close_date=dtm.datetime.now(tz=tz_bot.defaults.tzinfo)+dtm.timedelta(seconds=5)close_date=aware_close_date.replace(tzinfo=None)msg=awaittz_bot.send_poll(# The timezone returned from this is always converted to UTCchat_id=super_group_id,question=question,options=answers,close_date=close_date,read_timeout=60,        )msg.poll._unfreeze()# Sometimes there can be a few seconds delay, so don't let the test fail due to that->msg.poll.close_date=msg.poll.close_date.astimezone(aware_close_date.tzinfo)EAttributeError:'NoneType'objecthasnoattribute'astimezone'tests\test_bot.py:2750:AttributeError

To view more test analytics, go to theTest Analytics Dashboard
📢 Thoughts on this report?Let us know!

Copy link
Member

@harshil21harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

mostly looks quite good!

@harshil21harshil21 added the ⚙️ bot-apiaffected functionality: bot-api labelJan 1, 2025
@Bibo-JoshiBibo-Joshi changed the titleApi 8.2Full Support for Bot API 8.2Jan 2, 2025
Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Awesome! Thanks for the nice & quick PR. I left only a few nitpicks :)

Poolitzerand others added3 commitsJanuary 2, 2025 16:32
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
Copy link
Member

@harshil21harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

typo^2

@Bibo-JoshiBibo-Joshi merged commitf2dc017 intomasterJan 3, 2025
26 checks passed
@Bibo-JoshiBibo-Joshi deleted the api_8.2 branchJanuary 3, 2025 10:39
@Bibo-Joshi
Copy link
Member

Thanks again for the fast PR! I'll get the release started

@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 11, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@Bibo-JoshiBibo-JoshiBibo-Joshi approved these changes

@harshil21harshil21harshil21 approved these changes

Assignees
No one assigned
Labels
⚙️ bot-apiaffected functionality: bot-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Poolitzer@Bibo-Joshi@harshil21

[8]ページ先頭

©2009-2025 Movatter.jp