Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Supportallow_paid_broadcast inAIORateLimiter#4627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Bibo-Joshi merged 8 commits intomasterfromfeature/apd-ratelimiter
Jan 23, 2025

Conversation

Bibo-Joshi
Copy link
Member

closes#4578

A Release containing this feature should updatehttps://github.com/python-telegram-bot/python-telegram-bot/wiki/Avoiding-flood-limits accordingly

@Bibo-JoshiBibo-Joshi added ℹ️ needs-wiki-updateinformation: needs-wiki-update 🔌 enhancementpr description: enhancement labelsDec 31, 2024
@codecovCodecov
Copy link

codecovbot commentedDec 31, 2024
edited
Loading

❌ 3 Tests Failed:

Tests completedFailedPassedSkipped
657236569699
View the top 3 failed tests by shortest run time
tests._files.test_animation.TestAnimationWithoutRequest::test_expected_values
Stack Traces | 0.002s run time
self=<tests._files.test_animation.TestAnimationWithoutRequestobjectat0x7f9c59576100>animation=Animation(api_kwargs={'thumb': {'file_id':'AAMCBAADGQMAATRUmWeRRnqq-8_n1xy8G864s-P-cTq-AAI_GgACawiIUFZOcHUi83csAQAHcw...I_GgACawiIUFZOcHUi83csAQAHcwADNgQ',file_size=2744,file_unique_id='AQADPxoAAmsIiFB4',height=50,width=50),width=640)deftest_expected_values(self,animation):>assertanimation.mime_type==self.mime_typeEAssertionError:assert'image/gif'=='video/mp4'EE-video/mp4E+image/giftests/_files/test_animation.py:69:AssertionError
tests._files.test_animation.TestAnimationWithRequest::test_send_animation_url_file
Stack Traces | 0.171s run time
self=<tests._files.test_animation.TestAnimationWithRequestobjectat0x7f9c5958a0d0>bot=PytestExtBot[token=696188732:AAGVwEKfHHlNjscxEDNKAwkhGstZ_ko1mC0]chat_id='675666224'animation=Animation(api_kwargs={'thumb': {'file_id':'AAMCBAADGQMAATRUmWeRRnqq-8_n1xy8G864s-P-cTq-AAI_GgACawiIUFZOcHUi83csAQAHcw...I_GgACawiIUFZOcHUi83csAQAHcwADNgQ',file_size=2744,file_unique_id='AQADPxoAAmsIiFB4',height=50,width=50),width=640)asyncdeftest_send_animation_url_file(self,bot,chat_id,animation):message=awaitbot.send_animation(chat_id=chat_id,animation=self.animation_file_url,caption=self.caption        )assertmessage.caption==self.captionassertisinstance(message.animation,Animation)assertisinstance(message.animation.file_id,str)assertisinstance(message.animation.file_unique_id,str)assertmessage.animation.file_idassertmessage.animation.file_unique_id>assertmessage.animation.duration==animation.durationEAssertionError:assert1==0E+where1=Animation(api_kwargs={'thumb': {'file_id':'AAMCBAADGQMAATOxCGdzRPhVj8AXaIUpWELn9cUbFmGWAAI3AQACqsw9U9IUfTEHfB8TAQAHbQADNgQ','file_unique_id':'AQADNwEAAqrMPVNy','file_size':4451,'width':320,'height':180}},duration=1,file_id='CgACAgQAAxkDAAEzsQhnc0T4VY_AF2iFKVhC5_XFGxZhlgACNwEAAqrMPVPSFH0xB3wfEzYE',file_name='game.gif.mp4',file_size=4127,file_unique_id='AgADNwEAAqrMPVM',height=180,mime_type='video/mp4',thumbnail=PhotoSize(file_id='AAMCBAADGQMAATOxCGdzRPhVj8AXaIUpWELn9cUbFmGWAAI3AQACqsw9U9IUfTEHfB8TAQAHbQADNgQ',file_size=4451,file_unique_id='AQADNwEAAqrMPVNy',height=180,width=320),width=320).durationE+whereAnimation(api_kwargs={'thumb': {'file_id':'AAMCBAADGQMAATOxCGdzRPhVj8AXaIUpWELn9cUbFmGWAAI3AQACqsw9U9IUfTEHfB8TAQAHbQADNgQ','file_unique_id':'AQADNwEAAqrMPVNy','file_size':4451,'width':320,'height':180}},duration=1,file_id='CgACAgQAAxkDAAEzsQhnc0T4VY_AF2iFKVhC5_XFGxZhlgACNwEAAqrMPVPSFH0xB3wfEzYE',file_name='game.gif.mp4',file_size=4127,file_unique_id='AgADNwEAAqrMPVM',height=180,mime_type='video/mp4',thumbnail=PhotoSize(file_id='AAMCBAADGQMAATOxCGdzRPhVj8AXaIUpWELn9cUbFmGWAAI3AQACqsw9U9IUfTEHfB8TAQAHbQADNgQ',file_size=4451,file_unique_id='AQADNwEAAqrMPVNy',height=180,width=320),width=320)=Message(animation=Animation(api_kwargs={'thumb': {'file_id':'AAMCBAADGQMAATOxCGdzRPhVj8AXaIUpWELn9cUbFmGWAAI3AQACqsw9U9IUfTEHfB8TAQAHbQADNgQ','file_unique_id':'AQADNwEAAqrMPVNy','file_size':4451,'width':320,'height':180}},duration=1,file_id='CgACAgQAAxkDAAEzsQhnc0T4VY_AF2iFKVhC5_XFGxZhlgACNwEAAqrMPVPSFH0xB3wfEzYE',file_name='game.gif.mp4',file_size=4127,file_unique_id='AgADNwEAAqrMPVM',height=180,mime_type='video/mp4',thumbnail=PhotoSize(file_id='AAMCBAADGQMAATOxCGdzRPhVj8AXaIUpWELn9cUbFmGWAAI3AQACqsw9U9IUfTEHfB8TAQAHbQADNgQ',file_size=4451,file_unique_id='AQADNwEAAqrMPVNy',height=180,width=320),width=320),caption='Test *animation*',channel_chat_created=False,chat=Chat(first_name='PTB',id=675666224,last_name='Test user',type=<ChatType.PRIVATE>),date=datetime.datetime(2025,1,22,19,27,3,tzinfo=datetime.timezone.utc),delete_chat_photo=False,document=Document(api_kwargs={'thumb': {'file_id':'AAMCBAADGQMAATOxCGdzRPhVj8AXaIUpWELn9cUbFmGWAAI3AQACqsw9U9IUfTEHfB8TAQAHbQADNgQ','file_unique_id':'AQADNwEAAqrMPVNy','file_size':4451,'width':320,'height':180}},file_id='CgACAgQAAxkDAAEzsQhnc0T4VY_AF2iFKVhC5_XFGxZhlgACNwEAAqrMPVPSFH0xB3wfEzYE',file_name='game.gif.mp4',file_size=4127,file_unique_id='AgADNwEAAqrMPVM',mime_type='video/mp4',thumbnail=PhotoSize(file_id='AAMCBAADGQMAATOxCGdzRPhVj8AXaIUpWELn9cUbFmGWAAI3AQACqsw9U9IUfTEHfB8TAQAHbQADNgQ',file_size=4451,file_unique_id='AQADNwEAAqrMPVNy',height=180,width=320)),from_user=User(first_name='PTB tests on Travis using CPython 2.7',id=696188732,is_bot=True,username='ptb_travis_cpython_27_bot'),group_chat_created=False,message_id=3429541,supergroup_chat_created=False).animationE+and0=Animation(api_kwargs={'thumb': {'file_id':'AAMCBAADGQMAATRUmWeRRnqq-8_n1xy8G864s-P-cTq-AAI_GgACawiIUFZOcHUi83csAQAHcwADNgQ','file_unique_id':'AQADPxoAAmsIiFB4','file_size':2744,'width':50,'height':50}},duration=0,file_id='CgACAgQAAxkDAAE0VJlnkUZ6qvvP59ccvBvOuLPj_nE6vgACPxoAAmsIiFBWTnB1IvN3LDYE',file_name='game.gif',file_size=36535,file_unique_id='AgADPxoAAmsIiFA',height=360,mime_type='image/gif',thumbnail=PhotoSize(file_id='AAMCBAADGQMAATRUmWeRRnqq-8_n1xy8G864s-P-cTq-AAI_GgACawiIUFZOcHUi83csAQAHcwADNgQ',file_size=2744,file_unique_id='AQADPxoAAmsIiFB4',height=50,width=50),width=640).durationtests/_files/test_animation.py:271:AssertionError
tests._files.test_animation.TestAnimationWithRequest::test_send_all_args
Stack Traces | 0.692s run time
self=<tests._files.test_animation.TestAnimationWithRequestobjectat0x7f9c59581b80>bot=PytestExtBot[token=696188732:AAGVwEKfHHlNjscxEDNKAwkhGstZ_ko1mC0]chat_id='675666224'animation_file=<_io.BufferedReadername='.../tests/data/game.gif'>animation=Animation(api_kwargs={'thumb': {'file_id':'AAMCBAADGQMAATRUmWeRRnqq-8_n1xy8G864s-P-cTq-AAI_GgACawiIUFZOcHUi83csAQAHcw...I_GgACawiIUFZOcHUi83csAQAHcwADNgQ',file_size=2744,file_unique_id='AQADPxoAAmsIiFB4',height=50,width=50),width=640)thumb_file=<_io.BufferedReadername='.../tests/data/thumb.jpg'>asyncdeftest_send_all_args(self,bot,chat_id,animation_file,animation,thumb_file):message=awaitbot.send_animation(chat_id,animation_file,duration=self.duration,width=self.width,height=self.height,caption=self.caption,parse_mode="Markdown",disable_notification=False,protect_content=True,thumbnail=thumb_file,has_spoiler=True,show_caption_above_media=True,        )assertisinstance(message.animation,Animation)assertisinstance(message.animation.file_id,str)assertisinstance(message.animation.file_unique_id,str)assertmessage.animation.file_idassertmessage.animation.file_unique_id>assertmessage.animation.file_name==animation.file_nameEAssertionError:assert'game.gif.mp4'=='game.gif'EE-game.gifE+game.gif.mp4E         ?++++tests/_files/test_animation.py:237:AssertionError

To view more test analytics, go to theTest Analytics Dashboard
📢 Thoughts on this report?Let us know!

@Bibo-Joshi
Copy link
MemberAuthor

I can' reproduce the failure locally :/ I'll try to add some debug prints

@Bibo-JoshiBibo-Joshi marked this pull request as draftDecember 31, 2024 14:42
@Bibo-JoshiBibo-Joshi marked this pull request as ready for reviewDecember 31, 2024 16:21
@Bibo-Joshi
Copy link
MemberAuthor

Yeah, that worked 🎊

Copy link
Member

@harshil21harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Well written test and logic overall!

Copy link
Member

@harshil21harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

@Bibo-JoshiBibo-Joshi merged commit61b87ba intomasterJan 23, 2025
25 checks passed
@Bibo-JoshiBibo-Joshi deleted the feature/apd-ratelimiter branchJanuary 23, 2025 04:59
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 31, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@harshil21harshil21harshil21 approved these changes

@PoolitzerPoolitzerAwaiting requested review from Poolitzer

Assignees
No one assigned
Labels
🔌 enhancementpr description: enhancementℹ️ needs-wiki-updateinformation: needs-wiki-update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Supportallow_paid_broadcast inAIORateLimiter
2 participants
@Bibo-Joshi@harshil21

[8]ページ先頭

©2009-2025 Movatter.jp